fix(install): stop advising a -d flag that does not exist by Chemaclass · Pull Request #1222 · TypedDevs/bashunit

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass · 2026-08-14T07:39:21Z

🤔 Background

Related #1221

All three destination errors in install.sh ended with Choose another destination with -d. The script parses positional arguments only, so following that advice returns Invalid arguments — the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.

💡 Changes

Name the real interface in the not-a-directory, cannot-create and not-writable messages
Test by running the suggested form rather than string-matching it; the previous tests asserted the diagnosis line only, which is how an invented flag survived
Assert the advice on the run that actually prints it — a flag-shaped argument dies in the parser before any advice, so checking it there compares against an empty string and passes for free

All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes#1221

Chemaclass added the bug Something isn't working label Aug 14, 2026

Chemaclass self-assigned this Aug 14, 2026

Chemaclass merged commit 5e06837 into mainAug 14, 2026
40 checks passed