Skip to content

fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
Mar 19, 2026
Merged

fix(runner): detect set_up failure when source file does not exist #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down
28 changes: 28 additions & 0 deletions src/runner.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
exec 3>&1

local test_execution_result=$(
# Save subshell stdout to FD 5 so the EXIT trap can restore it.
# When set -e kills the subshell during a redirected block in
# execute_test_hook, the redirect leaks into the EXIT trap,
# causing export_subshell_context output to be lost.
exec 5>&1
# shellcheck disable=SC2064
trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
fi

# Run set_up and capture exit code without || to preserve errexit behavior
# shellcheck disable=SC2030
_BASHUNIT_SETUP_COMPLETED=false
local setup_exit_code=0
bashunit::runner::run_set_up "$test_file"
setup_exit_code=$?
_BASHUNIT_SETUP_COMPLETED=true
if [[ $setup_exit_code -ne 0 ]]; then
exit $setup_exit_code
fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
fi

set +e

# Detect unexpected subshell exit during set_up (Issue #611).
# When 'source' of a non-existent file fails under set -eE, the ERR trap
# does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
# Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
# Additionally, the stdout redirect from execute_test_hook leaks into the
# EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
# output reaches test_execution_result.
# shellcheck disable=SC2031
if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
exec 1>&5
if [[ "$exit_code" -eq 0 ]]; then
exit_code=1
fi
if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
bashunit::state::set_test_hook_failure "set_up"
bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
fi
fi

# Don't use || here - it disables ERR trap in the entire call chain
bashunit::runner::run_tear_down "$test_file"
local teardown_status=$?
Expand Down
23 changes: 23 additions & 0 deletions tests/acceptance/bashunit_setup_error_test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
# Clean up
rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
local fixture=$test_file

local error_line="✗ Error: Set up"
local tests_summary="Tests: 1 failed, 1 total"
local assertions_summary="Assertions: 0 failed, 0 total"

local actual_raw
set +e
actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
set -e

local actual
actual="$(printf "%s" "$actual_raw" | strip_ansi)"

assert_contains "$error_line" "$actual"
assert_contains "$tests_summary" "$actual"
assert_contains "$assertions_summary" "$actual"
assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}
1 change: 1 addition & 0 deletions tests/acceptance/coverage_hooks_test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
--coverage \
--no-coverage-report \
--coverage-min 0 \
--coverage-paths "src/globals.sh" \
--coverage-report "$LCOV_FILE" \
tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down
10 changes: 10 additions & 0 deletions tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
# shellcheck disable=SC1091
source ./this_file_does_not_exist.sh
}

function test_dummy() {
assert_same "foo" "foo"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(runner): detect set_up failure when source file does not exist by Chemaclass · Pull Request #612 · TypedDevs/bashunit · GitHub
Skip to content
fix(runner): detect set_up failure when source file does not exist#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Mar 19, 2026
 Merged


fix(runner): detect set_up failure when source file does not exist
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 3 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,9 @@

## Unreleased

### Fixed
- Fix `source` of non-existent file in `set_up()` silently passing all tests (#611)

## [0.34.0](https://github.com/TypedDevs/bashunit/compare/0.33.0...0.34.0) - 2026-03-17

### Added
Expand Down

28 changes: 28 additions & 0 deletions
src/runner.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -590,6 +590,11 @@ function bashunit::runner::run_test() {
 exec 3>&1

 local test_execution_result=$(
 # Save subshell stdout to FD 5 so the EXIT trap can restore it.
 # When set -e kills the subshell during a redirected block in
 # execute_test_hook, the redirect leaks into the EXIT trap,
 # causing export_subshell_context output to be lost.
 exec 5>&1
 # shellcheck disable=SC2064
 trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
 bashunit::state::initialize_assertions_count
Expand All@@ -612,9 +617,12 @@ function bashunit::runner::run_test() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
 setup_exit_code=$?
 _BASHUNIT_SETUP_COMPLETED=true
 if [[ $setup_exit_code -ne 0 ]]; then
 exit $setup_exit_code
 fi
Expand DownExpand Up@@ -829,6 +837,26 @@ function bashunit::runner::cleanup_on_exit() {
 fi

 set +e

 # Detect unexpected subshell exit during set_up (Issue #611).
 # When 'source' of a non-existent file fails under set -eE, the ERR trap
 # does not fire. On macOS Bash 3.2, $? is 0 in the EXIT trap; on Linux
 # Bash 5.x, $? is 1. In both cases the hook failure is not recorded.
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [[ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]]; then
 exec 1>&5
 if [[ "$exit_code" -eq 0 ]]; then
 exit_code=1
 fi
 if [[ -z "${_BASHUNIT_TEST_HOOK_FAILURE:-}" ]]; then
 bashunit::state::set_test_hook_failure "set_up"
 bashunit::state::set_test_hook_message "Hook 'set_up' failed unexpectedly (e.g., source of non-existent file)"
 fi
 fi

 # Don't use || here - it disables ERR trap in the entire call chain
 bashunit::runner::run_tear_down "$test_file"
 local teardown_status=$?
Expand Down

23 changes: 23 additions & 0 deletions
tests/acceptance/bashunit_setup_error_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,3 +106,26 @@ function test_bashunit_set_up_stops_on_first_failure() {
 # Clean up
 rm -f "$marker_file"
}

# Issue #611: Sourcing a non-existent file in set_up should fail the test
function test_bashunit_when_set_up_sources_nonexistent_file() {
 local test_file=./tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh
 local fixture=$test_file

 local error_line="✗ Error: Set up"
 local tests_summary="Tests: 1 failed, 1 total"
 local assertions_summary="Assertions: 0 failed, 0 total"

 local actual_raw
 set +e
 actual_raw="$(./bashunit --no-parallel --detailed --env "$TEST_ENV_FILE" "$test_file")"
 set -e

 local actual
 actual="$(printf "%s" "$actual_raw" | strip_ansi)"

 assert_contains "$error_line" "$actual"
 assert_contains "$tests_summary" "$actual"
 assert_contains "$assertions_summary" "$actual"
 assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" "$test_file")"
}

1 change: 1 addition & 0 deletions
tests/acceptance/coverage_hooks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ function test_coverage_tracks_src_lines_executed_in_hooks() {
 output=$(BASHUNIT_PARALLEL_RUN=false ./bashunit \
 --coverage \
 --no-coverage-report \
 --coverage-min 0 \
 --coverage-paths "src/globals.sh" \
 --coverage-report "$LCOV_FILE" \
 tests/acceptance/fixtures/test_coverage_hooks.sh 2>&1)
Expand Down

10 changes: 10 additions & 0 deletions
tests/acceptance/fixtures/test_bashunit_when_setup_sources_nonexistent_file.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env bash

function set_up() {
 # shellcheck disable=SC1091
 source ./this_file_does_not_exist.sh
}

function test_dummy() {
 assert_same "foo" "foo"
}
Loading