Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 4 commits into from
Apr 9, 2026
Merged

Fix post-increment causing silent exit under set -e #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2992c7a
coverage report (lcov/html) fix -- fixes #618
objctp Apr 9, 2026
e305891
Using pre-increment for set -e consistency
objctp Apr 9, 2026
dc7b89f
Update CHANGELOG for #618
objctp Apr 9, 2026
352e7d8
test: verify post-increment fix under set -e (#618)
Chemaclass Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down
20 changes: 10 additions & 10 deletions src/coverage.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
local line

while IFS= read -r line || [ -n "$line" ]; do
((lineno++))
bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
((++lineno))
bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
done <"$file"

echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
local line_content
line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
((count++))
((++count))
fi
done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
local line

while IFS= read -r line || [ -n "$line" ]; do
((lineno++))
((++lineno))

# Check for function definition patterns
# Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
((executable++))
((++executable))
local line_hits=${_hits_ref[$lineno]:-0}
if [ "$line_hits" -gt 0 ]; then
((hit++))
((++hit))
fi
fi
done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
local line
# shellcheck disable=SC2094
while IFS= read -r line || [ -n "$line" ]; do
((lineno++))
((++lineno))
bashunit::coverage::is_executable_line "$line" "$lineno" || continue
echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
local ln_content
ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
((fn_executable++))
((++fn_executable))
local ln_hits=${hits_by_line[$ln]:-0}
if [ "$ln_hits" -gt 0 ]; then
((fn_hit++))
((++fn_hit))
fi
fi
done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
local lineno=0
local line
while IFS= read -r line || [ -n "$line" ]; do
((lineno++))
((++lineno))

local escaped_line
escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down
2 changes: 1 addition & 1 deletion src/learn.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
for i in $(seq 1 $total_lessons); do
if bashunit::learn::is_completed "lesson_$i"; then
echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
((completed++)) || true
((++completed)) || true
else
echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
fi
Expand Down
10 changes: 5 additions & 5 deletions src/str.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
if [ "$original_char" = $'\x1b' ]; then
while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
result_left_text="$result_left_text${left_text:$j:1}"
((j++))
((++j))
done
result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
((j++))
((++j))
elif [ "$char" = "$original_char" ]; then
# Match the actual character
result_left_text="$result_left_text$char"
((i++))
((j++))
((++i))
((++j))
else
((j++))
((++j))
fi
done

Expand Down
23 changes: 23 additions & 0 deletions tests/unit/coverage_core_test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
local temp_file
temp_file=$(mktemp)

cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

# ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
# under set -e this silently terminates the function (#618)
local result
result=$(
set -e
bashunit::coverage::get_executable_lines "$temp_file"
)

assert_equals "2" "$result"

rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
BASHUNIT_COVERAGE="true"
BASHUNIT_COVERAGE_PATHS="/"
Expand Down
34 changes: 34 additions & 0 deletions tests/unit/coverage_reporting_test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
BASHUNIT_COVERAGE="true"
bashunit::coverage::init

local temp_file
temp_file=$(mktemp)
cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

local report_file
report_file=$(mktemp)

# ((lineno++)) when lineno=0 returns exit code 1 under set -e
# causing incomplete LCOV output (#618)
(
set -e
bashunit::coverage::report_lcov "$report_file"
)

local content
content=$(cat "$report_file")

assert_contains "end_of_record" "$content"
assert_contains "DA:2," "$content"
assert_contains "DA:3," "$content"

rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
BASHUNIT_COVERAGE="true"
bashunit::coverage::init
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/str_test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
"$actual"
}

function test_rpad_does_not_exit_under_set_e() {
# ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
# under set -e this silently terminates the function (#618)
local actual
actual=$(
set -e
bashunit::str::rpad "input" "1" 20
)

assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix post-increment causing silent exit under set -e#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 4 commits into

from

Apr 9, 2026
 Merged


Fix post-increment causing silent exit under set -e
#619
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2992c7a

coverage report (lcov/html) fix -- fixes #618


objctp Apr 9, 2026
e305891

Using pre-increment for set -e consistency


objctp Apr 9, 2026
dc7b89f

Update CHANGELOG for #618


objctp Apr 9, 2026
352e7d8

test: verify post-increment fix under set -e (#618)


Chemaclass Apr 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
- Fix spying on `echo` or `printf` causing bashunit to hang due to infinite recursion (#607)
- Fix invalid `.env.example` coverage threshold entry and copy `.env.example` to `.env` in CI test workflows so configuration parse errors are caught during automated test runs
- Fix `clock::now` shell-time parsing when `EPOCHREALTIME` uses a comma decimal separator
- Fix LCOV and HTML coverage reports generating incomplete/empty output due to post-increment operator causing silent exit under `set -e` (#618)

## [0.34.1](https://github.com/TypedDevs/bashunit/compare/0.34.0...0.34.1) - 2026-03-20

Expand Down

20 changes: 10 additions & 10 deletions
src/coverage.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -465,8 +465,8 @@ function bashunit::coverage::get_executable_lines() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((count++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" && ((++count))
 done <"$file"

 echo "$count"
Expand DownExpand Up@@ -498,7 +498,7 @@ function bashunit::coverage::get_hit_lines() {
 local line_content
 line_content=$(sed -n "${line_num}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$line_content" "$line_num"; then
 ((count++))
 ((++count))
 fi
 done

Expand DownExpand Up@@ -565,7 +565,7 @@ function bashunit::coverage::extract_functions() {
 local line

 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 # Check for function definition patterns
 # Pattern 1: function name() { or function name {
Expand DownExpand Up@@ -644,10 +644,10 @@ function bashunit::coverage::get_function_coverage() {
 line_content=$(sed -n "${lineno}p" "$file" 2>/dev/null) || continue

 if bashunit::coverage::is_executable_line "$line_content" "$lineno"; then
 ((executable++))
 ((++executable))
 local line_hits=${_hits_ref[$lineno]:-0}
 if [ "$line_hits" -gt 0 ]; then
 ((hit++))
 ((++hit))
 fi
 fi
 done
Expand DownExpand Up@@ -778,7 +778,7 @@ function bashunit::coverage::report_lcov() {
 local line
 # shellcheck disable=SC2094
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))
 bashunit::coverage::is_executable_line "$line" "$lineno" || continue
 echo "DA:${lineno},$(bashunit::coverage::get_line_hits "$file" "$lineno")"
 done <"$file"
Expand DownExpand Up@@ -1543,10 +1543,10 @@ EOF
 local ln_content
 ln_content=$(sed -n "${ln}p" "$file" 2>/dev/null) || continue
 if bashunit::coverage::is_executable_line "$ln_content" "$ln"; then
 ((fn_executable++))
 ((++fn_executable))
 local ln_hits=${hits_by_line[$ln]:-0}
 if [ "$ln_hits" -gt 0 ]; then
 ((fn_hit++))
 ((++fn_hit))
 fi
 fi
 done
Expand DownExpand Up@@ -1597,7 +1597,7 @@ EOF
 local lineno=0
 local line
 while IFS= read -r line || [ -n "$line" ]; do
 ((lineno++))
 ((++lineno))

 local escaped_line
 escaped_line=$(bashunit::coverage::html_escape "$line")
Expand Down

2 changes: 1 addition & 1 deletion
src/learn.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ function bashunit::learn::show_progress() {
 for i in $(seq 1 $total_lessons); do
 if bashunit::learn::is_completed "lesson_$i"; then
 echo " ${_BASHUNIT_COLOR_PASSED}✓${_BASHUNIT_COLOR_DEFAULT} Lesson $i completed"
 ((completed++)) || true
 ((++completed)) || true
 else
 echo " ${_BASHUNIT_COLOR_INCOMPLETE}○${_BASHUNIT_COLOR_DEFAULT} Lesson $i"
 fi
Expand Down

10 changes: 5 additions & 5 deletions
src/str.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,17 +40,17 @@ function bashunit::str::rpad() {
 if [ "$original_char" = $'\x1b' ]; then
 while [ "${left_text:$j:1}" != "m" ] && [ $j -lt ${#left_text} ]; do
 result_left_text="$result_left_text${left_text:$j:1}"
 ((j++))
 ((++j))
 done
 result_left_text="$result_left_text${left_text:$j:1}" # Append the final 'm'
 ((j++))
 ((++j))
 elif [ "$char" = "$original_char" ]; then
 # Match the actual character
 result_left_text="$result_left_text$char"
 ((i++))
 ((j++))
 ((++i))
 ((++j))
 else
 ((j++))
 ((++j))
 fi
 done

Expand Down

23 changes: 23 additions & 0 deletions
tests/unit/coverage_core_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -174,6 +174,29 @@ EOF
 rm -f "$temp_file"
}

function test_coverage_get_executable_lines_does_not_exit_under_set_e() {
 local temp_file
 temp_file=$(mktemp)

 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 # ((var++)) when var=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local result
 result=$(
 set -e
 bashunit::coverage::get_executable_lines "$temp_file"
 )

 assert_equals "2" "$result"

 rm -f "$temp_file"
}

function test_coverage_record_line_writes_to_file() {
 BASHUNIT_COVERAGE="true"
 BASHUNIT_COVERAGE_PATHS="/"
Expand Down

34 changes: 34 additions & 0 deletions
tests/unit/coverage_reporting_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -146,6 +146,40 @@ EOF
 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_lcov_completes_under_set_e() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init

 local temp_file
 temp_file=$(mktemp)
 cat >"$temp_file" <<'EOF'
#!/usr/bin/env bash
echo "line 1"
echo "line 2"
EOF

 echo "$temp_file" >"$_BASHUNIT_COVERAGE_TRACKED_FILES"

 local report_file
 report_file=$(mktemp)

 # ((lineno++)) when lineno=0 returns exit code 1 under set -e
 # causing incomplete LCOV output (#618)
 (
 set -e
 bashunit::coverage::report_lcov "$report_file"
 )

 local content
 content=$(cat "$report_file")

 assert_contains "end_of_record" "$content"
 assert_contains "DA:2," "$content"
 assert_contains "DA:3," "$content"

 rm -f "$temp_file" "$report_file"
}

function test_coverage_report_text_shows_no_files_message() {
 BASHUNIT_COVERAGE="true"
 bashunit::coverage::init
Expand Down

12 changes: 12 additions & 0 deletions
tests/unit/str_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,18 @@ function test_rpad_custom_width_padding_text_too_long_and_special_chars() {
 "$actual"
}

function test_rpad_does_not_exit_under_set_e() {
 # ((i++)) when i=0 evaluates to 0 (falsy) causing exit code 1;
 # under set -e this silently terminates the function (#618)
 local actual
 actual=$(
 set -e
 bashunit::str::rpad "input" "1" 20
 )

 assert_same "input 1" "$actual"
}

function test_rpad_width_smaller_than_right_word() {
 local actual=$(bashunit::str::rpad "foo" "verylongword" 5)

Expand Down
Loading