Skip to content

perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
Jul 16, 2026
Merged

perf(runner): build the provider map once per file, not twice #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down
6 changes: 5 additions & 1 deletion src/console_header.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
# Skip counting in parallel+simple mode for faster startup
total_tests=0
else
total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
# Read via the return slot, not $(...): the capture subshell would discard
# the provider-map cache find_total_tests builds per file, forcing the
# runner to re-scan each file with a second awk fork.
bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
fi

if bashunit::env::is_header_ascii_art_enabled; then
Expand Down
12 changes: 12 additions & 0 deletions src/helpers.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
local filter=${1:-}
shift || true

_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
if [ $# -eq 0 ]; then
echo 0
return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
continue
fi

# Build the provider map in THIS shell before the counting subshell: the
# subshell inherits it (its own build call becomes a cache hit), and when
# the caller runs in the main shell the runner's later build for the same
# file is a cache hit too — one awk scan per file instead of two.
bashunit::helper::build_provider_map "$file"

local file_count
file_count=$( (
# shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
total_count=$((total_count + file_count))
done

_BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
echo "$total_count"
}

Expand Down
7 changes: 4 additions & 3 deletions tests/acceptance/bashunit_run_forks_test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
if bashunit::check_os::is_windows; then
bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
awk_forks="$(grep -c . "$count_file" || true)"
fi

assert_less_or_equal_than 3 "$awk_forks"
assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
perf(runner): build the provider map once per file, not twice by Chemaclass · Pull Request #817 · TypedDevs/bashunit · GitHub
Skip to content
perf(runner): build the provider map once per file, not twice#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Jul 16, 2026
 Merged


perf(runner): build the provider map once per file, not twice
#817
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@
- `--jobs auto` / `-j auto` caps parallel concurrency at the CPU core count (portable across Linux/macOS/BSD); the default stays unlimited (#766)

### Changed
- Faster test runs: the data-provider map is built once per file in the main shell (the header's test count reads a return slot instead of a `$(...)` capture, so the cache survives for the runner) — one awk scan per file instead of two
- Faster test runs: stripping ANSI codes from short colored strings is pure bash now, so aligning the per-test execution time (shown on systems with a fork-free clock, e.g. Linux) no longer forks `sed` once per passing test
- Faster parallel runs: publishing each test's result file no longer forks `basename`, `mkdir` and an `echo | tr | sed` pipeline per test — the suite dir name is parameter expansion, the dir is pre-created once per file before workers spawn, and arg sanitizing is skipped without provider args (a 10-test parallel run dropped from 61 to 21 forks). No behaviour change
- Faster test runs: listing all defined functions uses the `compgen -A function` builtin instead of forking `declare -F | awk` (three call sites; 5 -> 3 `awk` forks per test file). No behaviour change
Expand Down

6 changes: 5 additions & 1 deletion
src/console_header.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,11 @@ function bashunit::console_header::print_version() {
 # Skip counting in parallel+simple mode for faster startup
 total_tests=0
 else
 total_tests=$(bashunit::helper::find_total_tests "$filter" "$@")
 # Read via the return slot, not $(...): the capture subshell would discard
 # the provider-map cache find_total_tests builds per file, forcing the
 # runner to re-scan each file with a second awk fork.
 bashunit::helper::find_total_tests "$filter" "$@" >/dev/null
 total_tests=$_BASHUNIT_HELPER_TOTAL_TESTS_OUT
 fi

 if bashunit::env::is_header_ascii_art_enabled; then
Expand Down

12 changes: 12 additions & 0 deletions
src/helpers.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,10 +526,15 @@ function bashunit::helper::get_latest_tag() {
 head -n 1
}

# Also written by find_total_tests so a main-shell caller can read the count
# without a $() capture (which would discard the provider-map cache built here).
_BASHUNIT_HELPER_TOTAL_TESTS_OUT=0

function bashunit::helper::find_total_tests() {
 local filter=${1:-}
 shift || true

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=0
 if [ $# -eq 0 ]; then
 echo 0
 return
Expand All@@ -543,6 +548,12 @@ function bashunit::helper::find_total_tests() {
 continue
 fi

 # Build the provider map in THIS shell before the counting subshell: the
 # subshell inherits it (its own build call becomes a cache hit), and when
 # the caller runs in the main shell the runner's later build for the same
 # file is a cache hit too — one awk scan per file instead of two.
 bashunit::helper::build_provider_map "$file"

 local file_count
 file_count=$( (
 # shellcheck source=/dev/null
Expand DownExpand Up@@ -590,6 +601,7 @@ function bashunit::helper::find_total_tests() {
 total_count=$((total_count + file_count))
 done

 _BASHUNIT_HELPER_TOTAL_TESTS_OUT=$total_count
 echo "$total_count"
}

Expand Down

7 changes: 4 additions & 3 deletions
tests/acceptance/bashunit_run_forks_test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,8 +126,9 @@ function test_running_a_test_file_does_not_fork_sort() {

# Regression guard: listing all defined functions must use the `compgen -A
# function` builtin, not a `declare -F | awk` fork. The remaining awk budget of
# a plain run is the per-file file scans (data-provider map, which runs in both
# the counting subshell and the runner, plus the duplicate-name check).
# a single-file run is one data-provider scan (built once in the main shell so
# the header-count subshell and the runner both hit the cache) plus the
# duplicate-name check.
function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 if bashunit::check_os::is_windows; then
 bashunit::skip "PATH shims are unreliable under Git Bash" && return
Expand DownExpand Up@@ -155,7 +156,7 @@ function test_running_a_test_file_stays_within_the_awk_fork_budget() {
 awk_forks="$(grep -c . "$count_file" || true)"
 fi

 assert_less_or_equal_than 3 "$awk_forks"
 assert_less_or_equal_than 2 "$awk_forks"
}

# Regression guard: a run must remove its run-output scratch directory on exit.
Expand Down
Loading