docs: stop instructing shfmt -w, and scope make sa correctly by Chemaclass · Pull Request #863 · TypedDevs/bashunit

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass · 2026-07-25T04:55:53Z

🤔 Background

Eight places in the contributor docs and skills told contributors to run shfmt -w .. On this repo that command reformats 146 tracked files and breaks make lint, because shfmt and .editorconfig disagree: indent_size = unset is read as tabs for tests/acceptance/**, and \-continued strings get collapsed past max_line_length = 120. Separately, make sa never linted three of the repo's own scripts.

💡 Changes

Replaces every shfmt -w . instruction with make lint as the formatting authority, and documents how to check for new shfmt drift instead of expecting none.
Scopes make sa's file list to git rather than find ., which descended into .claude/worktrees/ and re-linted the whole tree once per linked worktree.
make sa now also covers the extensionless bashunit, bin/pre-commit and bin/create-pr — 274 files, up from 271. All pass.

Eight places told contributors to run `shfmt -w .`. shfmt disagrees with .editorconfig on this repo two ways -- indent_size = unset is read as tabs for tests/acceptance/**, and `-continued strings get collapsed past the 120-char limit -- so following that instruction reformats 146 tracked files and breaks make lint. make lint is the formatting authority; record how to check for new drift instead. make sa built its file list with `find .`, which descends into .claude/worktrees/ (linting the whole tree once per linked worktree) and whose *.sh glob never covered the extensionless entrypoint, bin/pre-commit or bin/create-pr. Take the list from git instead, keeping find as the non-git fallback: 274 files now, including the three that were never checked.

…new test CI caught SC2164/SC1007 in the new test file that 'make sa' had passed. Cause: since #863 the file list comes from 'git ls-files', which only lists TRACKED files, so a brand-new script was invisible locally and first failed in CI -- exactly backwards. Add --others --exclude-standard. Verified by dropping an untracked offending script in the tree: make sa now fails on it.

Chemaclass added the documentation Improvements or additions to documentation label Jul 25, 2026

Chemaclass self-assigned this Jul 25, 2026

Chemaclass mentioned this pull request Jul 25, 2026
Is bin/create-pr still wanted? Unreferenced, unlinted, Bash 4 style #867
Closed