Uh oh!
There was an error while loading. Please reload this page.
refactor(console): group the rendering files into a src/console/ module - #942
Merged
Conversation
Group 2 under #940. Three files and 1220 lines that already shared a prefix and a concern: src/colors.sh -> src/console/colors.sh src/console_header.sh -> src/console/header.sh src/console_results.sh -> src/console/results.sh colors.sh defines the _BASHUNIT_COLOR_* palette the other two render with; both of those depend on the same env/helper/parallel set. The index sources them in the order the entrypoint used, so nothing about load order changes. The console_ prefix drops inside the directory, which now carries the concept. No function is renamed and no line of any moved file changes: git records all three as renames with a zero-line diff. .editorconfig pinned `indent_size = unset` for src/console_header.sh and is repointed at src/console/header.sh. Missing that would have silently applied the global rule to a file deliberately exempt from it -- the trap ADR-010 records from #928. Grouped before splitting on purpose: console_results.sh is also listed on #931 at 828 lines. Moving it into the module first means the eventual split happens inside src/console/ instead of the two issues colliding on the same file. The built artifact's code content is identical -- every difference is a comment or an embed marker -- and `bash build.sh bin -v` prints "Build verified". Related #940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #940 — Group 2.
Three files, 1220 lines, already sharing a prefix and a concern.
💡 Changes
colors.shdefines the_BASHUNIT_COLOR_*palette the other two render with; both depend on the sameenv/helper/parallelset. The index sources them in the order the entrypoint used, so load order is unchanged. No function renamed, zero-line diff on all three renames..editorconfig:29pinnedindent_size = unsetforsrc/console_header.sh. Repointed atsrc/console/header.sh— miss it and the global indent rule silently starts applying to a file deliberately exempt from it. This is the trap ADR-010 records from #928, and it's the only path reference to any of the three files in the entire repo.🔀 Grouped before splitting, deliberately
console_results.sh(828) is also listed on #931. Moving it into the module first means the eventual split happens insidesrc/console/, instead of the two issues colliding on the same file.✅ Verification
Built artifact's code content is identical — every difference is a comment or an embed marker — and
bash build.sh bin -v→✅ Build verified ✅. Function count 39 before and after; the non-blank line multiset lost nothing.Green: sequential (1604 passed, 0 failed) ·
--parallel --simple --strict·make sa·make lint· CI-mode ShellCheck ·git check-ignoreclean. Architecture map updated.