chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
Aug 2, 2026
Merged

chore(sa): remove 11 dead ShellCheck disable directives #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/config/parallel.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
# shellcheck disable=SC2153
local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
case "$target" in
*/bashunit/parallel/*)
Expand Down
1 change: 0 additions & 1 deletion src/console/line.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
# shellcheck disable=SC2034
local type=$1
local line=$2

Expand Down
1 change: 0 additions & 1 deletion src/coverage/engine.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

# Set DEBUG trap to record line execution
# Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
# shellcheck disable=SC2154
trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down
1 change: 0 additions & 1 deletion src/coverage/paths.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
IFS=','
local pattern
for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
# shellcheck disable=SC2254
case "$normalized_file" in
*$pattern*)
IFS="$old_ifs"
Expand Down
1 change: 0 additions & 1 deletion src/runner/exec.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
fi

# Run set_up and capture exit code without || to preserve errexit behavior
# shellcheck disable=SC2030
_BASHUNIT_SETUP_COMPLETED=false
local setup_exit_code=0
bashunit::runner::run_set_up "$test_file"
Expand Down
3 changes: 0 additions & 3 deletions src/runner/hooks.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
# Additionally, the stdout redirect from execute_test_hook leaks into the
# EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
# output reaches test_execution_result.
# shellcheck disable=SC2031
if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
exec 1>&5
if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
# NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
# itself returns non-zero, and an unconditional return skipped
# record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
# shellcheck disable=SC2154
trap '_BASHUNIT_HOOK_ERR_STATUS=$?
if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
# See the twin comment in execute_file_hook: conditional return keeps the
# early-exit semantics for intermediate failures without silently returning
# from THIS executor when the trap re-fires here on Bash >= 4 (#836).
# shellcheck disable=SC2154
trap '_BASHUNIT_HOOK_ERR_STATUS=$?
if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
set +Eu +o pipefail
Expand Down
1 change: 0 additions & 1 deletion src/runner/payload.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down
1 change: 0 additions & 1 deletion src/state/payload.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down
1 change: 0 additions & 1 deletion src/system/check_os.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(sa): remove 11 dead ShellCheck disable directives#963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Chemaclass
merged 1 commit into

from

Aug 2, 2026
 Merged


chore(sa): remove 11 dead ShellCheck disable directives
#963
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
src/config/parallel.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ function bashunit::parallel::must_stop_on_failure() {
}

function bashunit::parallel::cleanup() {
 # shellcheck disable=SC2153
 local target="$TEMP_DIR_PARALLEL_TEST_SUITE"
 case "$target" in
 */bashunit/parallel/*)
Expand Down

1 change: 0 additions & 1 deletion
src/console/line.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ _BASHUNIT_TOTAL_TESTS_COUNT=0
# Arguments: $1 - test type, $2 - already formatted line
##
function bashunit::console_results::print_line() {
 # shellcheck disable=SC2034
 local type=$1
 local line=$2

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/engine.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,6 @@ function bashunit::coverage::enable_trap() {

 # Set DEBUG trap to record line execution
 # Use ${VAR:-} to handle unset variables when set -u is active (in subshells)
 # shellcheck disable=SC2154
 trap 'bashunit::coverage::record_line "${BASH_SOURCE[0]:-}" "${LINENO:-}"' DEBUG
}

Expand Down

1 change: 0 additions & 1 deletion
src/coverage/paths.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,7 +63,6 @@ function bashunit::coverage::should_track() {
 IFS=','
 local pattern
 for pattern in $BASHUNIT_COVERAGE_EXCLUDE; do
 # shellcheck disable=SC2254
 case "$normalized_file" in
 *$pattern*)
 IFS="$old_ifs"
Expand Down

1 change: 0 additions & 1 deletion
src/runner/exec.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ function bashunit::runner::execute_test_body() {
 fi

 # Run set_up and capture exit code without || to preserve errexit behavior
 # shellcheck disable=SC2030
 _BASHUNIT_SETUP_COMPLETED=false
 local setup_exit_code=0
 bashunit::runner::run_set_up "$test_file"
Expand Down

3 changes: 0 additions & 3 deletions
src/runner/hooks.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,6 @@ function bashunit::runner::cleanup_on_exit() {
 # Additionally, the stdout redirect from execute_test_hook leaks into the
 # EXIT trap. Restore stdout from saved FD 5 so export_subshell_context
 # output reaches test_execution_result.
 # shellcheck disable=SC2031
 if [ "${_BASHUNIT_SETUP_COMPLETED:-true}" != "true" ]; then
 exec 1>&5
 if [ "$exit_code" -eq 0 ]; then
Expand DownExpand Up@@ -103,7 +102,6 @@ function bashunit::runner::execute_file_hook() {
 # NOT this executor: on Bash >= 4 the trap also fires HERE when the hook call
 # itself returns non-zero, and an unconditional return skipped
 # record_file_hook_failure entirely (silent failures, off-by-one counts, #836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_file_hook" ]; then
 set +Eu +o pipefail
Expand DownExpand Up@@ -224,7 +222,6 @@ function bashunit::runner::execute_test_hook() {
 # See the twin comment in execute_file_hook: conditional return keeps the
 # early-exit semantics for intermediate failures without silently returning
 # from THIS executor when the trap re-fires here on Bash >= 4 (#836).
 # shellcheck disable=SC2154
 trap '_BASHUNIT_HOOK_ERR_STATUS=$?
 if [ "${FUNCNAME[0]:-}" != "bashunit::runner::execute_test_hook" ]; then
 set +Eu +o pipefail
Expand Down

1 change: 0 additions & 1 deletion
src/runner/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -184,7 +184,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
 echo "$runtime_output"
}

# shellcheck disable=SC2295
##
# Parses the encoded per-test result's last line into the counts out-slots
# (_BASHUNIT_RUNNER_COUNTS_*_OUT). Pure read: never mutates the cumulative
Expand Down

1 change: 0 additions & 1 deletion
src/state/payload.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ unset _bashunit_base64_help
# in line parsing, so encode_base64 emits this token and both decode sites map it
# back to "". Single source of truth keeps the encode (helpers.sh) and decode
# (helpers.sh, runner/payload.sh) sides byte-identical.
# shellcheck disable=SC2034 # read cross-file in helpers.sh and runner/payload.sh
_BASHUNIT_BASE64_EMPTY_SENTINEL="_BASHUNIT_EMPTY_"

function bashunit::state::encode_field() {
Expand Down

1 change: 0 additions & 1 deletion
src/system/check_os.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2034
_BASHUNIT_OS="Unknown"
_BASHUNIT_DISTRO="Unknown"

Expand Down
Loading