Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); perf(assert): fold case with nocasematch instead of two tr forks by Chemaclass · Pull Request #977 · TypedDevs/bashunit · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## Unreleased

### Changed
- `assert_contains_ignore_case` folds case with `shopt -s nocasematch` on Bash 3.1+ instead of two `tr` subprocesses, and falls back to `tr` only on Bash 3.0. Roughly 10x faster in a run dominated by that assertion (300 calls: 1419ms -> 131ms), with identical results including non-ASCII folding
- Internal: `src/runner.sh` and `src/coverage.sh` are split into `src/runner/` and `src/coverage/` modules of single-responsibility files, each behind a `source`-only `index.sh` aggregator. A pure relocation, no behavior change; see [ADR-010](adrs/adr-010-src-module-directories.md) (#924, #925)

### Fixed
Expand Down
47 changes: 45 additions & 2 deletions src/assert/core.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,15 +325,58 @@ function assert_contains() {
bashunit::state::add_assertions_passed
}

##
# Whether `shopt -s nocasematch` exists. Introduced in Bash 3.1; bashunit's
# floor is 3.0, so the caller keeps a tr-based fallback for that one version.
# Returns: 0 when nocasematch is available (Bash >= 3.1), 1 otherwise.
##
function bashunit::assert::_supports_nocasematch() {
if [ "${BASH_VERSINFO[0]:-0}" -gt 3 ]; then
return 0
fi
[ "${BASH_VERSINFO[0]:-0}" -eq 3 ] && [ "${BASH_VERSINFO[1]:-0}" -ge 1 ]
}

function assert_contains_ignore_case() {
bashunit::assert::should_skip && return 0

local expected="$1"
local actual="$2"
local label_override="${3:-}"

# Bash 3.0 compatible: use tr for case-insensitive comparison
# (shopt nocasematch was introduced in Bash 3.1)
# nocasematch (Bash 3.1+) folds case inside the `case` itself, which costs no
# fork at all; the two `tr` pipelines below cost two. Measured on Bash 3.2:
# 0.087ms per call versus 12.8ms. Both fold non-ASCII identically in a UTF-8
# locale -- `ñü` matches `ÑÜ` either way -- which rules out the tempting
# pure-bash A-Z loop, since that is ASCII-only and would silently stop
# matching accented text that matches today.
#
# Prior state is saved and restored rather than blindly unset: nocasematch is
# a global shell option and a user's test file may already have set it. `shopt
# -q` is a builtin, so the save costs nothing.
if bashunit::assert::_supports_nocasematch; then
local nocase_was_set=1
shopt -q nocasematch || nocase_was_set=0
shopt -s nocasematch

local matched=1
case "$actual" in
*"$expected"*) ;;
*) matched=0 ;;
esac

[ "$nocase_was_set" -eq 1 ] || shopt -u nocasematch

if [ "$matched" -eq 0 ]; then
bashunit::assert::fail_with "${label_override:-}" "${actual}" "to contain" "${expected}"
return
fi

bashunit::state::add_assertions_passed
return
fi

# Bash 3.0 only: nocasematch does not exist, so fold with tr.
local expected_lower
local actual_lower
expected_lower=$(printf '%s' "$expected" | tr '[:upper:]' '[:lower:]')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/assert/string_test.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -236,3 +236,64 @@ function test_unsuccessful_assert_string_not_matches_format() {
"42 items" "to not match format" "%d items")" \
"$(assert_string_not_matches_format "%d items" "42 items")"
}

# Guarded on the same predicate the production code uses: `shopt -u nocasematch`
# is itself an "invalid shell option name" error on Bash 3.0, so these tests
# cannot even set up there -- and on 3.0 the tr path runs, where there is no
# option to leak.
#
# nocasematch is a global shell option, so the fast path in
# assert_contains_ignore_case has to leave it exactly as it found it -- a user's
# test file may have set it deliberately, and silently clearing it would change
# how their own `case` statements match.
function test_assert_contains_ignore_case_leaves_nocasematch_unset_when_it_was_unset() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -u nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

if shopt -q nocasematch; then
bashunit::fail "nocasematch leaked ON into the caller"
fi
}

function test_assert_contains_ignore_case_leaves_nocasematch_set_when_it_was_set() {
if ! bashunit::assert::_supports_nocasematch; then
bashunit::skip "nocasematch requires Bash 3.1+"
return
fi

shopt -s nocasematch

assert_contains_ignore_case "world" "Hello WORLD"

local still_set=1
shopt -q nocasematch || still_set=0
shopt -u nocasematch

assert_equals "1" "$still_set"
}

# Non-ASCII folding is why the tr fallback cannot be replaced with a pure-bash
# A-Z loop: where the locale folds accented text, both nocasematch and tr do it
# and an ASCII-only loop would silently stop matching.
#
# Whether it folds at all is a property of the platform's locale, not of
# bashunit: under LC_ALL=C neither path folds, which is correct and is what Git
# Bash on Windows does. So the capability is probed first and the assertion is
# skipped where it does not apply, rather than pinning a UTF-8-only outcome.
function test_assert_contains_ignore_case_folds_non_ascii() {
local folded
folded=$(printf '%s' "ÑÜ" | tr '[:upper:]' '[:lower:]')
if [ "$folded" != "ñü" ]; then
bashunit::skip "locale does not fold non-ASCII case"
return
fi

assert_contains_ignore_case "ñü" "Test ÑÜ string"
assert_contains_ignore_case "ÑÜ" "test ñü string"
}
Loading