Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Impl serializer interface and json serializer - #18
Merged
iankuan merged 3 commits intoOct 8, 2017
Conversation
iankuan
commented
Oct 1, 2017
Contributor
It was almost done, isn't it ? Just give me some unittests. However, you could read this material, How to write a good commit message(Chinese). I'm not saying you did a bad job. Just have something you can improve. |
Open
iankuan
commented
Oct 4, 2017
Contributor
@as23041248 , please rebase your branch. We import many features like CI and Makefile, which can test your code automatically. |
iankuan
self-requested a review
October 5, 2017 07:25
amikaiforce-pushed
the
feature/serialization
branch
from
October 5, 2017 20:42
e29ae6e to
9a682b6Compareiankuan
approved these changes
Oct 6, 2017
iankuan
left a comment
Contributor
There was a problem hiding this comment.
Seems great. By the way, I notice that this branch feature/serialization doesn't catch up mainline. Please rebasing it after few minutes.
amikaiforce-pushed
the
feature/serialization
branch
2 times, most recently
from
October 6, 2017 15:45
fd0b9d1 to
4d1f642Compareiankuan
reviewed
Oct 7, 2017
amikaiforce-pushed
the
feature/serialization
branch
2 times, most recently
from
October 7, 2017 02:44
7a18341 to
3c2c250CompareThe serializer in Json convert python dict to string(raw data), and deserializer convert string(raw data) to python dict.
amikaiforce-pushed
the
feature/serialization
branch
from
October 7, 2017 03:17
3c2c250 to
884ea53Compareiankuan
suggested changes
Oct 7, 2017
iankuan
left a comment
Contributor
There was a problem hiding this comment.
Meld last two commits into one. Hint: "rebase -i" and then "-f fixup".
Test json serializer by converting between python dict and raw json data.
amikaiforce-pushed
the
feature/serialization
branch
from
October 7, 2017 05:42
884ea53 to
22acb5cCompareiankuan
approved these changes
Oct 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is add a feature which describes in #12.
The three thing i do in this PR: