Uh oh!
There was an error while loading. Please reload this page.
Allow non-rectangular grids to use side labels - #376
Merged
Conversation
cvanelteren
marked this pull request as draft
October 21, 2025 14:04
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cvanelteren
commented
Oct 21, 2025
CollaboratorAuthor
Need to fix a few edge cases |
cvanelteren
commented
Oct 22, 2025
CollaboratorAuthor
Added a few examples in #375 |
cvanelteren
commented
Oct 22, 2025
CollaboratorAuthor
cvanelteren
marked this pull request as ready for review
October 22, 2025 06:47
beckermr
approved these changes
Oct 22, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#375
The checks in
def _get_align_axes(self, side)assumes that the plots are on a rectangular grid. However, for non rectangular layouts this causes an error. This PR uses_get_border_axesto determine the outside.