Uh oh!
There was an error while loading. Please reload this page.
Feature: allow cycle objects to be set on rc - #378
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables users to set cycle objects directly on the rc configuration, improving user experience for defining default cycle colors. Users can now pass color lists or Cycle objects in addition to string names.
Key Changes:
- Extended
_validate_cmapfunction to handleCycleobjects and color lists when validating cycle configurations - Added test coverage for different cycle input formats (string names, color lists,
Cycleobjects, and invalid inputs)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ultraplot/internals/rcsetup.py | Modified _validate_cmap to accept and validate Cycle objects and iterables when cycle=True parameter is set |
| ultraplot/tests/test_config.py | Added parameterized test to verify cycle setting behavior with various input types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
Closes#200
With the improved
Configuratorinstantiation, we can now more easily allow for cycle passing to enhance user experience to define default cycle colors. This PR introduces the ability for users to pass on lists of colors orCycleobjects directly.