Uh oh!
There was an error while loading. Please reload this page.
Xarray accessor updates to remove automatic quantification and in-place operations - #1430
Conversation
jthielen
commented
Jul 28, 2020
I realized that this uses |
dopplershift
left a comment
There was a problem hiding this comment.
This looks good. I like the extensive additions in notes in the docs and comments.
dopplershift
commented
Jul 29, 2020
Eh, what's another two months shorter on our xarray horizon? Go ahead and bump. Would just 0.14.0 work? (Could always let our tests determine that.) If not 0.14.1's fine. Hey does that mean we can work around some of those deprecated functions now? 😄 |
dopplershift
commented
Jul 29, 2020
Answered my own question here as I did some digging for other reasons. We need 0.14.1 for |
Yeah, xarray hasn't been the best at following semver...their "patch" releases sometimes have new APIs and breaking changes.
I'll take a look after this PR! |
a2772ba to
699d161Compare699d161 to
f6191ebComparedopplershift
commented
Jul 29, 2020
Not sure why Travis shows queued, it's passed. Codacy is...well, wrong. |
jthielen
commented
Jul 29, 2020
So now it's mostly just the updated version of #1353 to go before 1.0-rc2? |
dopplershift
commented
Jul 29, 2020
Sounds great. I promise this one will actually get my attention. Thanks for knocking these out. I'm really happy with how CI is working with these. |
Description Of Changes
Update of #1378 on new fork and after rebase on latest master. Original comment below:
Checklist