Add PactHook hook on ethereum - #7160
Merged
Ponx merged 1 commit intoSep 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Review: hooks/ethereum/0x9f3c19ad49f71f513817e4c40a53b0c5ce410044.json
Address Flags
Address suffix 0x0044 = 0b01000100 → lowest 14 bits confirmed:
- Bit 6 →
afterSwap: true✓ - Bit 2 →
afterSwapReturnsDelta: true✓ - All other bits = 0; all other flags
false✓
Properties
| Property | Filed | Verdict |
|---|---|---|
dynamicFee |
false |
✓ — No lpFeeOverride or updateDynamicLPFee(). Fee is a hardcoded 3% taken in afterSwap. |
upgradeable |
false |
✓ — poolManager is immutable. pactGame/devWallet are mutable fee-recipient addresses, not upgradeable logic. No proxy, no delegatecall, no SELFDESTRUCT. |
requiresCustomSwapData |
false |
✓ — hookData parameter is explicitly ignored in afterSwap. |
vanillaSwap |
false |
✓ — afterSwapReturnsDelta is true; hook returns totalFee.toInt128() to take 3% of the output token, modifying what swappers receive. |
swapAccess |
"none" |
✓ — No beforeSwap flag. The onlyPoolManager modifier on afterSwap is standard callback authentication, not swap-access gating. |
Metadata
verifiedSource: true— confirmed by source metadata ✓chainId: 1— ethereum mainnet ✓name: "PactHook"— matches on-chain contract name ✓description— accurately describes the fixed 3% fee split (2% topactGame, 1% todevWallet) via afterSwap return delta, with owner-controlled mutable recipient addresses ✓
All fields are correct and consistent with the verified on-chain source.
Ponx
approved these changes
Sep 16, 2026
Ponx
left a comment
Collaborator
There was a problem hiding this comment.
Bot review verified; bitmask/flags/properties check out. LGTM.
Ponx
deleted the
hooks/ethereum/0x9f3c19ad49f71f513817e4c40a53b0c5ce410044
branch
September 16, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Charges a fixed 3% fee on each swap's output token, taking 2% to a game contract (pactGame) and 1% to a dev wallet (devWallet) via afterSwap with a return delta. Fee recipient addresses are mutable by an owner.
Flags
Properties
Warnings
Closes #7146