Skip to content

Rd & logs refactoring - #1399

Merged
Domonion merged 7 commits into
mainfrom
kononov-rd-refactoring-1
Nov 26, 2022
Merged

Rd & logs refactoring#1399
Domonion merged 7 commits into
mainfrom
kononov-rd-refactoring-1

Conversation

@Domonion

@DomonionDomonion commented Nov 18, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Multiple refactorings and enhacements for process starting.
Removed UtSettings.logConcreteExecutionErrors and UtSettings.engineProcessLogLevel switches.
Logs for engine and concrete executor processes are always enabled.
Switched log configuration to utbot-intellij/log4j2.xml.
Use UtSettings#getIdeaProcessLogConfigFile from ~/.utbot/settings.properties to configure logs for engine and concrete executor processes without rebuilding plugin.

Enabling suspend and port choosing by utsettings.
Run configurations for debugging.
Instant process death detection.
Orphan processes termination system.
Some text loading optimization.
ChildProcess -> InstrumentedProcess.
Rd-based UtSettings for InstrumentedProcess.

partially solves #1365
fix#1427

Type of Change

  • Refactoring (typos and non-functional changes)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

CI

denis-fokin
denis-fokin reviewed Nov 22, 2022
View reviewed changes
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
denis-fokin
denis-fokin reviewed Nov 22, 2022
View reviewed changes
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Outdated
denis-fokin
denis-fokin reviewed Nov 22, 2022
View reviewed changes
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Outdated
denis-fokin
denis-fokin reviewed Nov 22, 2022
View reviewed changes
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Outdated
denis-fokin
denis-fokin reviewed Nov 22, 2022
View reviewed changes
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Outdated
denis-fokin
denis-fokin reviewed Nov 22, 2022
View reviewed changes
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Outdated
sergeypospelov
sergeypospelov approved these changes Nov 23, 2022
View reviewed changes
Comment threaddocs/contributing/InterProcessDebugging.md Outdated
Comment threaddocs/RD for UnitTestBot.md Outdated
Comment threadutbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/rd/InstrumentedProcess.kt Outdated
Comment threadutbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt
Comment threadutbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/generator/CodeGenerationController.kt
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/ClientProcessUtil.kt Outdated
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/RdSettingsContainer.kt Outdated
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/UtRdCoroutineScope.kt Outdated
@sergeypospelov
sergeypospelov self-requested a review November 23, 2022 07:00
sergeypospelov
sergeypospelov requested changes Nov 23, 2022
View reviewed changes

@sergeypospelovsergeypospelov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to missclick :)

@Domonion

Domonion commented Nov 25, 2022

Copy link
Copy Markdown
CollaboratorAuthor

@denis-fokin@sergeypospelov@olganaumenko please, read design docs

@Domonion
Domonionforce-pushed the kononov-rd-refactoring-1 branch from b79d242 to f02b9f2CompareNovember 25, 2022 10:29
@Domonion
Domonionforce-pushed the kononov-rd-refactoring-1 branch from f02b9f2 to 14ad3dbCompareNovember 25, 2022 13:02
denis-fokin
denis-fokin approved these changes Nov 25, 2022
View reviewed changes
Comment threadutbot-framework/src/main/kotlin/org/utbot/framework/codegen/domain/Domain.kt Outdated
Comment threadutbot-framework/src/main/kotlin/org/utbot/framework/concrete/UtExecutionInstrumentation.kt
Comment thread...strumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessRunner.kt Outdated
Comment thread.../src/main/kotlin/org/utbot/instrumentation/rd/generated/InstrumentedProcessRoot.Generated.kt
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/UtRdUtil.kt
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/UtRdUtil.kt
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/exceptions/InstantProcessDeathException.kt
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/exceptions/InstantProcessDeathException.kt
Comment threaddocs/RD for UnitTestBot.md Outdated
@Domonion
Domonionforce-pushed the kononov-rd-refactoring-1 branch 2 times, most recently from da2882e to d211adfCompareNovember 25, 2022 15:09
@Domonion
[rd-refactoring]
1e34350
Multiple refactorings and enhacements for process starting.
Removed UtSettings.logConcreteExecutionErrors and UtSettings.engineProcessLogLevel switches.
Logs for engine and concrete executor processes are always enabled.
Switched log configuration to utbot-intellij/log4j2.xml.
Use UtSettings#getIdeaProcessLogConfigFile from ~/.utbot/settings.properties to configure logs for engine and concrete executor processes without rebuilding plugin.
@Domonion
[rd-refactoring]
a2c9b5a
Enabling suspend and port choosing by utsettings
Run configurations for debugging
Instant process death detection
Orphan processes termination system
Some text loading optimization
ChildProcess -> InstrumentedProcess
Rd-based UtSettings for InstrumentedProcess
@Domonion
[rd-refactoring]
124b14c
Rd version bump, model regeneration typos and small adjustments
@Domonion
[design-docs]
8d172d5
Rewriting design docs for inter process debugging and rd.
Completely new design doc go inter process logging
@Domonion
[rd-factoring]
9019740
review fix
@Domonion
[rd-factoring]
c7b4b9b
review fix
@Domonion
Domonionforce-pushed the kononov-rd-refactoring-1 branch from d211adf to c7b4b9bCompareNovember 25, 2022 15:11
@Domonion
[rd-factoring]
f56ace2
debug run configurations fix
@Domonion
Domonion enabled auto-merge (squash) November 25, 2022 16:43
sergeypospelov
sergeypospelov approved these changes Nov 26, 2022
View reviewed changes
Comment threaddocs/RD for UnitTestBot.md
UtBot consists of 3 different processes:
1. `IDEA process` - the one where plugin part executes. Also can be called `plugin process`, `IDE process`.
2. `Engine process` - process where unit test generation engine executes.
3. `InstrumentedProces` - process where concrete execution takes place.

@sergeypospelovsergeypospelovNov 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3.`InstrumentedProces` - process where concrete execution takes place.
3.`InstrumentedProcess` - process where concrete execution takes place.

@Domonion
Domonion merged commit 46cfad6 into mainNov 26, 2022
@Domonion
Domonion deleted the kononov-rd-refactoring-1 branch November 26, 2022 03:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@korifeykorifeykorifey approved these changes
@denis-fokindenis-fokindenis-fokin approved these changes
@sergeypospelovsergeypospelovsergeypospelov approved these changes
@olganaumenkoolganaumenkoAwaiting requested review from olganaumenko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rd refactoring

4 participants

@Domonion@korifey@denis-fokin@sergeypospelov