Skip to content

Nested classes & logs - #1447

Merged
Domonion merged 1 commit into
mainfrom
kononov-nested-classes
Dec 2, 2022
Merged

Nested classes & logs#1447
Domonion merged 1 commit into
mainfrom
kononov-nested-classes

Conversation

@Domonion

Copy link
Copy Markdown
Collaborator

Description

  1. fixesMissed source file for nested class #1359
  2. changes log formatting in IDEA process

Type of Change

Please delete options that are not relevant.

  • Minor bug fix (non-breaking small changes)
  • Bug fix (non-breaking change which fixes an issue)

Automated Testing

CI

@Domonion
Domonionforce-pushed the kononov-nested-classes branch from 7933d1c to a64c2b4CompareDecember 1, 2022 08:35
1. fixes#1359
2. changes log formatting in IDEA process
@Domonion
Domonionforce-pushed the kononov-nested-classes branch from a64c2b4 to 5ebd6ddCompareDecember 1, 2022 08:37
@Domonion
Domonion enabled auto-merge (squash) December 1, 2022 09:13
@amandelpie

Copy link
Copy Markdown
Collaborator

Looks great, now it founds the source file for the nested class correctly

@amandelpieamandelpie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've debugged and tested for a few scenarios, the existing solution gives us ability to find the source file for the nested classes

@Domonion
Domonion merged commit 7f92cb3 into mainDec 2, 2022
@Domonion
Domonion deleted the kononov-nested-classes branch December 2, 2022 13:15
tamarinvs19 pushed a commit that referenced this pull request Dec 6, 2022
[rd & logs]
1. fixes#1359
2. changes log formatting in IDEA process
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missed source file for nested class

2 participants

@Domonion@amandelpie