Skip to content

Logging redesign - #1547

Merged
Domonion merged 1 commit into
mainfrom
kononov-logs
Feb 8, 2023
Merged

Logging redesign#1547
Domonion merged 1 commit into
mainfrom
kononov-logs

Conversation

@Domonion

@DomonionDomonion commented Dec 16, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  1. Added Logger model to rd
  2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file
  3. Removed instrumentedProcessLogLevel
  4. auxiliary log functions
  5. stop process rdcall
  6. UtRd Loggers redesigned to have the same logging pattern

Fixes#1122

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (typos and non-functional changes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Domonion
Domonionforce-pushed the kononov-logs branch 2 times, most recently from 3f72d71 to 7f97aa5CompareDecember 16, 2022 14:15
@Domonion
Domonion marked this pull request as draft December 16, 2022 14:32
@Domonion
Domonionforce-pushed the kononov-logs branch 2 times, most recently from 3c3a624 to 145e036CompareDecember 16, 2022 14:41
@DomonionDomonion changed the title Utbot loggingLogging redesignDec 16, 2022
@Domonion
Domonionforce-pushed the kononov-logs branch 2 times, most recently from ae0546c to 4d86647CompareJanuary 26, 2023 13:02
@Domonion
Domonion marked this pull request as ready for review January 26, 2023 13:03
sergeypospelov
sergeypospelov requested changes Jan 27, 2023
View reviewed changes

@sergeypospelovsergeypospelov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK after fixing remarks, but I didn't dive into details deeply. I guess, you need to update docs.

Comment threadutbot-core/src/main/kotlin/org/utbot/common/Logging.kt Outdated
Comment threadutbot-core/src/main/kotlin/org/utbot/common/Logging.kt
Comment threadutbot-framework/src/main/kotlin/org/utbot/framework/codegen/tree/CgMethodConstructor.kt Outdated
Comment thread...instrumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessMain.kt
Comment threadutbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt Outdated
@DomonionDomonion reopened this Jan 27, 2023
@Domonion
Domonion enabled auto-merge (squash) January 27, 2023 16:20
@DomonionDomonion self-assigned this Jan 27, 2023
@DomonionDomonion added the comp-logging Issue is related to Logging label Jan 27, 2023
@Domonion
Domonion disabled auto-merge January 30, 2023 12:50
@alisevych

alisevych commented Feb 2, 2023

Copy link
Copy Markdown
Member

@Domonion Please add logging of Summarization phase: started - ended.

EgorkaKulikov
EgorkaKulikov reviewed Feb 7, 2023
View reviewed changes

@EgorkaKulikovEgorkaKulikov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGNP2m

Comment threaddocs/InterprocessLogging.md Outdated
Comment threaddocs/InterprocessLogging.md Outdated
Comment threaddocs/InterprocessLogging.md Outdated
Comment threaddocs/InterprocessLogging.md Outdated
Comment threaddocs/InterprocessLogging.md Outdated
Comment threadutbot-maven/src/main/kotlin/org/utbot/maven/plugin/GenerateTestsAndSarifReportMojo.kt
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/ClientProcessUtil.kt Outdated
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/loggers/UtRdRemoteLogger.kt Outdated
Comment threadutbot-rd/src/main/kotlin/org/utbot/rd/loggers/UtRdRemoteLogger.kt
Comment threadutbot-summary/src/main/kotlin/org/utbot/summary/Summarization.kt Outdated
@EgorkaKulikov
EgorkaKulikov self-requested a review February 8, 2023 13:54
@Domonion
Domonion enabled auto-merge (squash) February 8, 2023 13:55
@Domonion
[utbot-logs]
719262f
Complete logs redesign:
1. Added Logger model to rd.
2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file.
3. Removed UtSettings.instrumentedProcessLogLevel
4. Auxiliary log functions
5. UtRdLoggers redesigned to have the same logging pattern
6. From now log4j2.xml is responsible for instrumentation process log configuration
7. Added summarization start/end log notifications and instrumented process starting messages.
8. Design doc for logs, clarifying comments and refactoring.
9. Changed `bracket` to `logMeasure`. its signature from plain string message to lambda to remove extra interpolation when message log level is not supported/
@Domonion
Domonion merged commit 1e5b593 into mainFeb 8, 2023
@Domonion
Domonion deleted the kononov-logs branch February 8, 2023 14:32
@alisevychalisevych added the ctg-enhancement New feature, improvement or change request label Feb 9, 2023
@alisevychalisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorkaKulikovEgorkaKulikovEgorkaKulikov approved these changes
@sergeypospelovsergeypospelovsergeypospelov approved these changes

Assignees

@DomonionDomonion

Labels

comp-loggingIssue is related to Loggingctg-enhancementNew feature, improvement or change request

Projects

UTBot Java
Archived in project

Milestone

2023.3 Release

Development

Successfully merging this pull request may close these issues.

Testability: add log records on test generation phases

4 participants

@Domonion@alisevych@EgorkaKulikov@sergeypospelov