Skip to content

Minimize exceptions in signature - #418

Merged
EgorkaKulikov merged 3 commits into
mainfrom
andrey-t/minimize-signature-exceptions
Jul 8, 2022
Merged

Minimize exceptions in signature#418
EgorkaKulikov merged 3 commits into
mainfrom
andrey-t/minimize-signature-exceptions

Conversation

@sofurihafe

@sofurihafesofurihafe commented Jul 5, 2022•
edited by EgorkaKulikov
Loading

Copy link
Copy Markdown
Member

Description

Filters exceptions in test method signature.

Fixes # (344)
Fixes # (250)

Type of Change

Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Automated Testing

Run utbot-samples pipeline.

Manual Scenario

Create a method throwing many exceptions inheriting each other. Verify that only required ones are represented in test signature.

@sofurihafesofurihafe added the comp-codegen Issue is related to code generator label Jul 5, 2022
@sofurihafe
sofurihafe requested a review from DamtevJuly 5, 2022 13:09
@sofurihafe
sofurihafe marked this pull request as draft July 5, 2022 13:09
@EgorkaKulikovEgorkaKulikov removed the comp-codegen Issue is related to code generator label Jul 5, 2022
@EgorkaKulikovEgorkaKulikov linked an issue Jul 5, 2022 that may be closed by this pull request
Minimize exceptions in test methods signature #344
Closed
@sofurihafe
sofurihafeforce-pushed the andrey-t/minimize-signature-exceptions branch from 4e83a9c to eebd835CompareJuly 5, 2022 13:30
Damtev
Damtev requested changes Jul 5, 2022
View reviewed changes

@DamtevDamtev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

Comment thread...framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/context/CgContext.kt Outdated
Comment thread...framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/context/CgContext.kt
@sofurihafe
sofurihafeforce-pushed the andrey-t/minimize-signature-exceptions branch from 0b82bcb to 3bd66fcCompareJuly 5, 2022 14:43
Damtev
Damtev requested changes Jul 5, 2022
View reviewed changes
Comment thread...framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/context/CgContext.kt Outdated
@sofurihafe
sofurihafeforce-pushed the andrey-t/minimize-signature-exceptions branch 5 times, most recently from 166419c to c82c702CompareJuly 6, 2022 15:52
@sofurihafe
sofurihafeforce-pushed the andrey-t/minimize-signature-exceptions branch from c82c702 to 389b5c2CompareJuly 6, 2022 15:53
@EgorkaKulikov
EgorkaKulikov self-requested a review July 6, 2022 16:59
Damtev
Damtev requested changes Jul 7, 2022
View reviewed changes

@DamtevDamtev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix some problems with BuiltinClassId

Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/util/ThrowableUtils.kt Outdated
Comment threadutbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/util/ThrowableUtils.kt Outdated
Comment thread...framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/context/CgContext.kt Outdated
Comment thread...framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/context/CgContext.kt Outdated
@sofurihafe
sofurihafeforce-pushed the andrey-t/minimize-signature-exceptions branch from 3e039e0 to 4280aa0CompareJuly 7, 2022 10:50
@sofurihafe
sofurihafeforce-pushed the andrey-t/minimize-signature-exceptions branch from 4280aa0 to 59289abCompareJuly 7, 2022 11:12
@Damtev
Damtev marked this pull request as ready for review July 7, 2022 12:12
@EgorkaKulikovEgorkaKulikov linked an issue Jul 7, 2022 that may be closed by this pull request
Redundant exceptions in parametrized tests data provider methods signatures #250
Closed
Damtev
Damtev requested changes Jul 7, 2022
View reviewed changes

@DamtevDamtev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big problem found, need to discuss

Comment thread...rc/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgCallableAccessManager.kt
Damtev
Damtev approved these changes Jul 8, 2022
View reviewed changes

@DamtevDamtev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, everything is OK

@EgorkaKulikov
EgorkaKulikov merged commit 31fbc83 into mainJul 8, 2022
@EgorkaKulikov
EgorkaKulikov deleted the andrey-t/minimize-signature-exceptions branch July 8, 2022 07:50
rudolf101 added a commit that referenced this pull request Jul 8, 2022
@rudolf101
Squashed commit of the following:
bf2e0e7
commit 31fbc83
Author: Andrey Tarbeev <dinis.taranov@mail.ru>
Date: Fri Jul 8 10:50:52 2022 +0300
Minimize exceptions in signature (#418)
* Minimize exceptions in test methods signatures
commit 63eb9b0
Author: Yury Kamenev <yurkam447@gmail.com>
Date: Thu Jul 7 15:13:45 2022 +0300
Removed always used coverage-based minimization strategy (#450)
commit fe0f7f8
Author: Yury Kamenev <yurkam447@gmail.com>
Date: Thu Jul 7 14:19:53 2022 +0300
Disabled NPE checks for non-public library fields by default (#353)
commit d1b51fe
Author: Yury Kamenev <yurkam447@gmail.com>
Date: Thu Jul 7 13:44:46 2022 +0300
Fixed NPE for processing static field as first statement in MUT (#433)
commit acc2fff
Author: Nikita Vlaev <nikitavlaev00@gmail.com>
Date: Wed Jul 6 15:37:28 2022 +0300
Added ForceStaticMockListener to run "configure mockito-inline" action.
Refactored url listener in notifications.
commit 80c2328
Author: Nikita Stroganov <54814796+IdeaSeeker@users.noreply.github.com>
Date: Thu Jul 7 11:21:13 2022 +0300
Support -P parameters in the utbot-gradle (#377)
commit a92e289
Author: Sergey Pospelov <sergeypospelov59@gmail.com>
Date: Tue Jul 5 10:29:45 2022 +0300
Fix searching of modifiers field for JDK 8-17
commit 9a3acb6
Author: Amandel Pie <105506115+amandelpie@users.noreply.github.com>
Date: Wed Jul 6 14:16:09 2022 +0300
Disabled clustering of tests generated by Fuzzer (#431)
* Disabled clustering of tests generated by Fuzzer
* Refactored the multiple calls
commit c09568f
Author: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>
Date: Wed Jul 6 10:21:52 2022 +0300
Existing test file without test class obstruct generation #160 (#425)
commit 2ec8fb3
Author: Denis Fokin <Denis.Fokin@gmail.com>
Date: Tue Jul 5 16:52:42 2022 +0300
Better naming
commit 68c66ef
Author: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>
Date: Tue Jul 5 19:51:55 2022 +0300
SVG logo contains 'inaccurate' holes #330 (#411)
commit 1d48789
Author: Dmitrii Timofeev <dtim@comitative.com>
Date: Tue Jul 5 17:08:38 2022 +0300
Workaround: run concrete execution for invokedynamic
commit 65d95c1
Author: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>
Date: Tue Jul 5 19:42:55 2022 +0300
Plugin fails with an exception if no SDK is configured for the test module #399 (#424)
commit 6f9f2d8
Author: Maksim Pelevin <maks.pelevin@gmail.com>
Date: Tue Jul 5 17:49:58 2022 +0300
Fix CNFE: kotlin.collections.ArrayDeque in ContestEstimator (#419)
commit 67cc7d9
Author: Denis Fokin <Denis.Fokin@gmail.com>
Date: Tue Jul 5 11:58:40 2022 +0300
Put concrete executor jar in resources for contest estimator
commit 63e2252
Author: Alena Lisevych <37301492+alisevych@users.noreply.github.com>
Date: Tue Jul 5 15:48:29 2022 +0300
Tooltips correction for #343 (#410)
Co-authored-by: Alena Lisevych <>
commit 8b3defa
Author: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>
Date: Tue Jul 5 13:22:31 2022 +0300
Write access exception on test generating in Idea project with JDK 11 #350 (#409)
commit c02883c
Author: Amandel Pie <105506115+amandelpie@users.noreply.github.com>
Date: Tue Jul 5 11:21:21 2022 +0300
Enables 40 tests for utbot-summary module (#389)
* Repair testPow
* Repaired ReturnExampleTest tests
* Restored SummaryCycleTest.kt
* Restored all the tests
commit 65c07f8
Author: Victoria <32179813+victoriafomina@users.noreply.github.com>
Date: Tue Jul 5 09:51:44 2022 +0300
Update Dockerfile_java_cli (#396)
commit 3b21112
Author: Alexey Menshutin <alex.menshutin99@gmail.com>
Date: Mon Jul 4 21:16:53 2022 +0300
ToString support for abstract collection using makeSymbolic #391
commit c2673df
Author: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>
Date: Mon Jul 4 21:56:43 2022 +0300
IDE fatal error during tests generation #68 (#379)
commit 43693fb
Author: Nikita Vlaev <vlaev.nikita@huawei.com>
Date: Mon Jul 4 18:59:57 2022 +0300
Bring back test class generation (#403)
commit 1c01193
Author: Yury Kamenev <yurkam447@gmail.com>
Date: Mon Jul 4 20:24:03 2022 +0300
Added the wrapper for static methods of java.util.List (#400)
commit a805f31
Author: Nikita Vlaev <vlaev.nikita@huawei.com>
Date: Fri Jul 1 20:16:28 2022 +0300
Add title pane with unsupported jdk notification (#373)
commit 16c13fb
Author: Dmitrii Timofeev <dtim@comitative.com>
Date: Mon Jul 4 18:35:36 2022 +0300
Initiate concrete execution if a wrapper method is missing (#392)
If a JVM class is overridden but a method is missing from the wrapper,
the engine will discard the path and fall back to concrete execution
instead of analysing the real JVM code graph.
This approach fixes the problem with methods that have been introduced
in newer JDKs. Now wrappers are mostly limited to Java 1.8 interfaces
and fail to analyze methods like `String::isBlank` or `String::lines`
when the code runs under JDK 11. Building graphs from the real JDK code
fails because the wrapper does not have private fields that the original
code uses.
TODO: to allow symbolic analysis of the code, missing methods should be
actually implemented in corresponding wrappers.
Vassiliy-Kudryashov pushed a commit that referenced this pull request Jul 11, 2022
@sofurihafe@Vassiliy-Kudryashov
Minimize exceptions in signature (#418)
edc482a
* Minimize exceptions in test methods signatures
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorkaKulikovEgorkaKulikovEgorkaKulikov approved these changes
@DamtevDamtevDamtev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

UTBot Java
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minimize exceptions in test methods signature Redundant exceptions in parametrized tests data provider methods signatures

3 participants

@sofurihafe@EgorkaKulikov@Damtev