Uh oh!
There was an error while loading. Please reload this page.
Disabled tests for autogenerated functions #457 - #505
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dtim
left a comment
There was a problem hiding this comment.
Algorithmically and conceptually the PR is good, but there are some issues with the code organization. I would like also suggest some stylistic changes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dc010f6 to
a245bc6Compare
dtim
left a comment
There was a problem hiding this comment.
LGTM. If possible, it would be nice to have some unit tests in CLI.
Description
Disabled tests for autogenerated methods (values, valueOf) for enum classes.
Fixes#457
Type of Change
How Has This Been Tested?
Automated Testing
No new tests currently added (in progress)
Manual Scenario
com.google.common.base.CaseFormat.*-- it will no more generate tests forvaluesandvalueOf.Checklist (remove irrelevant options):