Uh oh!
There was an error while loading. Please reload this page.
Rename UtTestCase #519 - #517
Merged
Merged
Conversation
sergeypospelovforce-pushed
the
sergey/ut-test-case-refactoring
branch
from
July 13, 2022 12:17
9fe794a to
ba1ac51Comparemmvpm
requested changes
Jul 13, 2022
mmvpm
left a comment
Collaborator
There was a problem hiding this comment.
Please rename the following as well:
- org/utbot/sarif/SarifReport.kt:73
- org/utbot/framework/plugin/sarif/GenerateTestsAndSarifReportFacade.kt:35
- org/utbot/framework/plugin/sarif/GenerateTestsAndSarifReportFacade.kt:72
- org/utbot/contest/Contest.kt:336
- org/utbot/external/api/UtBotJavaApi.kt:111
mmvpm
commented
Jul 13, 2022
Collaborator
Also:
|
mmvpm
commented
Jul 13, 2022
Collaborator
Also:
|
sergeypospelov
commented
Jul 13, 2022
MemberAuthor
Looks like
shouldn't be renamed |
mmvpm
commented
Jul 13, 2022
Collaborator
Also:
|
mmvpm
requested changes
Jul 13, 2022
Collaborator
There was a problem hiding this comment.
Also:
- org/utbot/external/api/UtBotJavaApi.kt:153 (with comment)
- org/utbot/external/api/UtBotJavaApi.kt:105
- (?) org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt:1365
- (?) org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt:1312
- (?) org/utbot/framework/codegen/model/constructor/tree/CgTestClassConstructor.kt:44
sergeypospelov
commented
Jul 13, 2022
MemberAuthor
Looks like these uses of "case" are correct. |
mmvpm
approved these changes
Jul 13, 2022
sergeypospelovforce-pushed
the
sergey/ut-test-case-refactoring
branch
from
July 13, 2022 14:07
c6ab919 to
e8b13dbComparesergeypospelovforce-pushed
the
sergey/ut-test-case-refactoring
branch
from
July 13, 2022 14:09
e8b13db to
861990cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UtTestCaseclass toUtMethodTestSet....testSet....UtValueTestCasetoUtMethodValueTestSet. FYI: it's only used in our tests.Fixes#519
Type of Change
Checklist: