Skip to content

Classifications of error on TP and FP - #170

Draft
S1eGa wants to merge 4 commits into
UnitTestBot:mainfrom
S1eGa:error-possible
Draft

Classifications of error on TP and FP#170
S1eGa wants to merge 4 commits into
UnitTestBot:mainfrom
S1eGa:error-possible

Conversation

@S1eGa

Copy link
Copy Markdown
Collaborator

NOTE: This PR is based on sarif-report branch.

Adds classification of errors to:

  • Confident --- errors which may be considered as True Positives
  • Possible --- errors which may be considered as False Positives

Error is Confident if predicate on it is inferable from current constraint set.

In extra cases it requires workaround:

  • For NPE we should consider symbols on which value of pointers dependent
  • For assert fails we need to take a look at the result of the last br instruction

In SARIF reports this classification reflected in error level in JSON: error and warning values correspondingly.
For logging added POSSIBLE ERROR log line.

@S1eGa
S1eGaforce-pushed the error-possible branch 3 times, most recently from 94ca494 to ab63f8fCompareFebruary 26, 2024 12:20
@codecov-commenter

codecov-commenter commented Feb 26, 2024

Copy link
Copy Markdown

Codecov Report

Merging #170 (ec4df69) into main (ebca2f3) will decrease coverage by 0.05%.
The diff coverage is 72.95%.

❗ Current head ec4df69 differs from pull request most recent head 2538e1e. Consider uploading reports for the commit 2538e1e to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## main #170 +/- ##
==========================================
- Coverage 69.74% 69.70% -0.05% 
==========================================
Files 219 219 Lines 31170 31240 +70 Branches 6875 6898 +23 ==========================================
+ Hits 21740 21776 +36 - Misses 6849 6879 +30 - Partials 2581 2585 +4 
FilesCoverage Δ
lib/Core/CodeEvent.h100.00% <100.00%> (ø)
lib/Core/ExecutionState.cpp71.83% <100.00%> (+0.19%)⬆️
lib/Core/ExecutionState.h89.90% <ø> (ø)
lib/Core/Executor.h74.07% <ø> (ø)
lib/Expr/ExprUtil.cpp84.69% <ø> (-7.15%)⬇️
lib/Support/ErrorHandling.cpp56.92% <0.00%> (-1.81%)⬇️
lib/Core/SpecialFunctionHandler.cpp73.50% <69.23%> (-0.03%)⬇️
lib/Core/Executor.cpp74.24% <73.00%> (-0.19%)⬇️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@S1eGa@codecov-commenter