Skip to content

Performance improvement for large scenes#198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Extrys wants to merge 1 commit into
base:master
Choose a base branch
from
Open

Performance improvement for large scenes #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Assets/NavMeshComponents/Scripts/NavMeshSurface.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -341,10 +341,11 @@ List<NavMeshBuildSource> CollectSources()
}

if (m_IgnoreNavMeshAgent)
sources.RemoveAll((x) => (x.component != null && x.component.gameObject.GetComponent<NavMeshAgent>() != null));
sources.RemoveAll((x) => x.component != null && x.component is NavMeshAgent);

@ExtrysExtrysAug 4, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been made in this way due to Its much more efficient a type check tan getting from the "already obtained component" the component with he typed object, and checking if is not null

So
x.component != null && x.component is NavMeshAgent
Is better than
x.component != null && x.component.gameObject.GetComponent() != null

This even let you use this in an asynchronous way since no unity API is being called
I have this oriented to async building, in my project, and it works fantastic

Is for that the second part of the condition is changed in both lines
So i see like a bad move not merging this, honestly

Comment thread
Extrys marked this conversation as resolved.

if (m_IgnoreNavMeshObstacle)
sources.RemoveAll((x) => x.component != null && x.component is NavMeshObstacle);

if (m_IgnoreNavMeshObstacle)
sources.RemoveAll((x) => (x.component != null && x.component.gameObject.GetComponent<NavMeshObstacle>() != null));

AppendModifierVolumes(ref sources);

Expand Down