Skip to content

refactor: [Optimize accessors] NetworkTransform - #3907

Merged
noellie-velez merged 12 commits into
develop-2.0.0from
chore/simplify-accessors-network-transform
Apr 2, 2026
Merged

refactor: [Optimize accessors] NetworkTransform#3907
noellie-velez merged 12 commits into
develop-2.0.0from
chore/simplify-accessors-network-transform

Conversation

@noellie-velez

@noellie-veleznoellie-velez commented Mar 18, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Purpose of this PR

Jira ticket

closes: #3743
MTT-14675

Changelog

  • Changed: Improve performance of NetworkTransform.

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

N/A

noellie-velez
noellie-velez commented Mar 18, 2026
View reviewed changes
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs Outdated
noellie-velez
noellie-velez commented Mar 18, 2026
View reviewed changes
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs Outdated
noellie-velez
noellie-velez commented Mar 18, 2026
View reviewed changes
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs Outdated
@noellie-velez
noellie-velez marked this pull request as ready for review March 18, 2026 18:12
@noellie-velez
noellie-velez requested a review from a team as a code ownerMarch 18, 2026 18:12
@noellie-veleznoellie-velez changed the title chore: Use cached network manager instead of propertychore: [Optimize bitfield accessors] NetworkTransformMar 18, 2026
noellie-velez
noellie-velez commented Mar 19, 2026
View reviewed changes
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs Outdated
@noellie-velez
noellie-velez marked this pull request as draft March 25, 2026 19:34
@noellie-veleznoellie-velez changed the title chore: [Optimize bitfield accessors] NetworkTransformchore: [Optimize accessors] NetworkTransformMar 26, 2026
EmandM
EmandM reviewed Mar 30, 2026
View reviewed changes
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs Outdated
@noellie-velez
noellie-velez marked this pull request as ready for review March 31, 2026 10:28
@noellie-velez
noellie-velez enabled auto-merge (squash) March 31, 2026 10:43
@EmandM
EmandM disabled auto-merge April 1, 2026 14:15
NoelStephensUnity
NoelStephensUnity approved these changes Apr 1, 2026
View reviewed changes

@NoelStephensUnityNoelStephensUnity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided a suggested change to assignment of the cached tick rate and NetworkObject to group the more "constant" cached value assignments into the same location.

Other than that minor adjustment... it looks good to me! 👍

Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs Outdated
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Comment threadcom.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
/// </summary>
/// <param name="networkTransform"></param>
private static void RegisterForTickUpdate(NetworkTransform networkTransform)
private void RegisterForTickUpdate()

@NoelStephensUnityNoelStephensUnityApr 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and adjustment!
:godmode:

@noellie-velez
noellie-velez merged commit 296b9f5 into develop-2.0.0Apr 2, 2026
23 checks passed
@noellie-velez
noellie-velez deleted the chore/simplify-accessors-network-transform branch April 2, 2026 13:59
@EmandMEmandM mentioned this pull request Apr 2, 2026
Closed
6 tasks
@EmandMEmandM mentioned this pull request Apr 14, 2026
Closed
@noellie-veleznoellie-velez changed the title chore: [Optimize accessors] NetworkTransformrefactor: [Optimize accessors] NetworkTransformApr 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmandMEmandMEmandM approved these changes
@NoelStephensUnityNoelStephensUnityAwaiting requested review from NoelStephensUnity

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noellie-velez@EmandM@NoelStephensUnity