Uh oh!
There was an error while loading. Please reload this page.
fix: networkmanager cannot be started within OnClientStopped or OnServerStopped callbacks - #3908
Conversation
Adding additional information about some events we have added but do not cover in NetworkManager. Added additional information about starting NetworkManager within OnClientStopped or OnServerStopped. Adding changelog entry.
jabbacakes
left a comment
There was a problem hiding this comment.
Mostly just wording tweaks. Main change is moving the info about pre-shutdown notifications to the bottom of its section. It makes more sense to me to introduce the 'you will definitely want to do this' info first, and then add the if statement of 'and you can also do this if you need something else'.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
Uh oh!
There was an error while loading. Please reload this page.
Purpose of this PR
Based on a user submitted issue, adding the ability to start NetworkManager from within NetworkManager.OnClientStopped or NetworkManager.OnServerStopped.
If a host starts itself within the NetworkManager.OnClientStopped, then it will skip invoking the NetworkManager.OnServerStopped since it will have already been started again.
fixes: #2703
Jira ticket
MTT-10150
Changelog
NetworkManagerfrom within one of its stopped callbacks at the end of shutdown it will fail to start properly.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No backport. This will be v2.x specific.