Uh oh!
There was an error while loading. Please reload this page.
Source gen adjustments to deal with GCX_PREEMP - #123
Merged
Conversation
Some of the embedding apis don't have GCX_PREEMP. Previously the generator always wrote them. Only write this call if the method already includes it.
joncham
commented
Mar 14, 2023
Member
Yes, this is just a hack as IIRC some embedding API call other embedding APIs which is not expected/handled ATM. |
UnityAlex
approved these changes
Mar 14, 2023
mrvoorhe pushed a commit
that referenced
this pull request
Mar 19, 2025
* JIT: Introduce `LclVarDsc::lvIsMultiRegDest`
With recent work to expand returned promoted locals into `FIELD_LIST`
the only "whole references" of promoted locals we should see is when
stored from a multi-reg node. This is the only knowledge the backend
should need for correctness purposes, so introduce a bit to track this
property, and switch the backend to check this instead.
The existing `lvIsMultiRegRet` is essentially this + whether the local
is returned. We should be able to remove this, but it is currently used
for some heuristics in old promotion, so keep it around for now.
* JIT: Add some more constant folding in lowering
Add folding for shifts and certain binops that are now getting produced
late due to returned `FIELD_LIST` nodes.
win-arm64 example:
```csharp
[MethodImpl(MethodImplOptions.NoInlining)]
static ValueTask<byte> Foo()
{
return new ValueTask<byte>(123);
}
```
```diff
G_M17084_IG02: ;; offset=0x0008
mov x0, xzr
- mov w1, #1
- mov w2, wzr
- mov w3, #123
- orr w2, w2, w3, LSL #16
- orr w1, w2, w1, LSL #24
- ;; size=24 bbWeight=1 PerfScore 4.00
+ mov w1, #0x17B0000
+ ;; size=8 bbWeight=1 PerfScore 1.00
```
* Feedbackmrvoorhe pushed a commit
that referenced
this pull request
Apr 17, 2026
This adds command line and test support for feature switches. And enables them in descriptors. Some tests added, no properties/events as our descriptor parsing doesn't support properties/events yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the embedding apis don't have GCX_PREEMP. Previously the generator always wrote them.
Only write this call if the method already includes it.
As an alternative, I thought about refactoring the
NoNativeWrapperAttributeinto aNativeWrapperOptionsAttributethat accepted aNativeWrapperOptionsenum. Then addingNoWrapperandNoGCX_PREEMPoptions. I didn't go that route because I thought it would be nice to auto detect so I don't forget to add it.Based on the comment after the
GCX_PREEMPcalls, I suspect that this logic is going to be revisited anyways. I figured this is good enough for now.