Uh oh!
There was an error while loading. Please reload this page.
docs: replaced remaining Guard.with_tiny() references with Guard(mode… - #130
Conversation
Greptile SummaryThe PR updates remaining user-facing references from the deprecated
Confidence Score: 3/5The PR should not merge until the outstanding quickstart downgrade is addressed, because failed ML initialization can silently leave users with weaker regex-only scanning. The quickstart requests the tiny model but leaves Files Needing Attention: README.md
|
| Filename | Overview |
|---|---|
| README.md | Replaces deprecated ML constructor references and enables model auto-download in the quickstart. |
| sdk/benchmarks/run.py | Updates the --ml help text to name the current Guard constructor. |
| sdk/scripts/smoke_ml_hooks.py | Updates a module docstring without changing smoke-test behavior. |
Reviews (10): Last reviewed commit: "chore: re-trigger Greptile on current cl..." | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
All two review comments addressed! |
chiruu12
left a comment
There was a problem hiding this comment.
Verified: all three with_tiny sites are gone, --ml help text and the smoke script docstring read correctly, 6 checks green.
One behaviour change in the quickstart. with_tiny() defaults to auto_download=True, require_ml=False, so require_ml=True is not equivalent:
with_tiny() auto_download=True require_ml=False
Guard(model="tiny") auto_download=False require_ml=False
Guard(model="tiny", auto_download_model=True) auto_download=True require_ml=False <- match
With require_ml=True, someone who ran pip install unplug-ai and pasted the snippet gets ModelError: require_ml=true but model tier 'tiny' could not be loaded instead of falling back to regex. Drop it and keep auto_download_model=True, which the "downloads once, cached" line above does need.
Also needs a rebase, README conflicts with dev. When you do, keep dev's F1 0.58 / recall 0.41. Your branch still has the old 0.56 / 0.39, which was corrected in #126.
Nice catch finding all three README sites when the issue only named one.
…l='tiny') ClosesUnplugAI#118 Note: the issue cited README.md:60, but the root README had three total with_tiny references (quickstart, 'What ships today' table, and the benchmark paragraph). Updated all three for consistency within the file. MIGRATION.md and the deprecation test left untouched as instructed.
156dac5 to
b3852b4CompareUh oh!
There was an error while loading. Please reload this page.
cookieshop02
commented
Aug 17, 2026
Fixed : the leftover marker and duplicate paragraph were removed in aaa584e. The failing review was on a stale intermediate commit,@greptile-apps please re-review the current head. |
cookieshop02
commented
Aug 17, 2026
Fixed : the leftover marker and duplicate paragraph were removed in aaa584e. The failing review was on a stale intermediate commit,@greptile-apps please re-review it. |
Uh oh!
There was an error while loading. Please reload this page.
…l='tiny')
Summary
Replaced the remaining
Guard.with_tiny()references with the newGuard(model="tiny")API in:1.
README.md(quickstart, "What ships today" table, benchmark paragraph)2.
sdk/benchmarks/run.py(--mlhelp text)3.
sdk/scripts/smoke_ml_hooks.py(module docstring)Checklist
dev(see BRANCHING.md)cd sdk && make check-cipasses locallysdk/README.md/sdk/docs/