Skip to content

feat: option to show chapters inline in details screen - #96

Open
sang765 wants to merge 11 commits into
UsagiApp:develfrom
sang765:feat/inline-chapter-list
Open

sang765 wants to merge 11 commits into
UsagiApp:develfrom
sang765:feat/inline-chapter-list

Conversation

@sang765

@sang765 sang765 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

What

Adds a new setting under Details screen appearance — "Chapters in details screen" — that replaces the chapters bottom sheet with an inline chapter list rendered directly below Related manga in the manga details screen.

Why

The bottom-sheet chapter list is convenient but hides the chapters behind a pull-up gesture. With the new option the chapter list is always visible when scrolling the details page, matching the "everything on one screen" pattern used by other readers.

How

  • Setting: details_chapters_inline (Boolean, default false) in pref_details_appearance.xml, exposed via AppSettings.isChaptersInlineEnabled.
  • Layouts (phone only): new "Chapters" section after group_related in activity_details.xml (with a read MaterialSplitButton reusing ReadButtonDelegate) and activity_details_classic.xml (no split button — classic already has its own read button). Both wrap the section in group_chapters_inline (GONE by default) and host the existing ChaptersFragment in container_chapters_inline.
  • Activities: when the option is on, DetailsActivity / DetailsClassicActivity hide container_bottom_sheet + navbarDim, show the inline group, add ChaptersFragment programmatically (so the fragment is never created when the option is off), attach ReadButtonDelegate (modern), and return null from BottomSheetOwner.bottomSheet so snackbars anchor to the scroll view. Peek-height bottom padding and navbar-dim insets handling are skipped while inline.
  • Tablets (w600dp-land) are intentionally unchanged — they already render chapters in the side card and have no bottom sheet, so the setting is a no-op there.

Limitations

  • Phone layouts only (see above).
  • While inline, the Pages/Bookmarks tabs and the sheet toolbar toggles (reverse order, grid, downloaded-only) are not reachable from the details screen.

Test

  • ./gradlew :app:compileDebugKotlin passes.

Hà Tiến Sáng added 3 commits August 15, 2026 16:01
New setting in Details screen appearance that hides the chapters
bottom sheet and shows the chapter list directly below Related manga
(phone layouts only; tablets keep the side-card chapters).
@sang765 sang765 self-assigned this Aug 16, 2026
@dragonx943 dragonx943 added this to Usagi Aug 17, 2026
@dragonx943 dragonx943 moved this to Doing in Usagi Aug 17, 2026
@sang765
sang765 marked this pull request as ready for review August 17, 2026 13:04
@sang765
sang765 requested a review from dragonx943 as a code owner August 17, 2026 13:04
@sang765
sang765 force-pushed the feat/inline-chapter-list branch from f76d26a to c01c4cf Compare August 18, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Doing

Development

Successfully merging this pull request may close these issues.

2 participants