Uh oh!
There was an error while loading. Please reload this page.
Kill stdio MCP children when a dial is interrupted - #1654
Merged
Conversation
Deploying with |
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs | executor-cloud | 73cdb9f | Aug 18 2026, 04:12 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli@executor-js/config@executor-js/execution@executor-js/sdk@executor-js/codemode-core@executor-js/runtime-quickjs@executor-js/plugin-file-secrets@executor-js/plugin-graphql@executor-js/plugin-keychain@executor-js/plugin-mcp@executor-js/plugin-onepassword@executor-js/plugin-openapiexecutorcommit: |
RhysSullivan
marked this pull request as ready for review
August 18, 2026 16:19
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1631.
Cancelling an in-flight health check or tool discovery (HTTP 499 on app refresh, or the 15s discovery timeout) abandoned the MCP connect handshake without closing the transport. The spawned stdio child stayed alive indefinitely; for
docker run -i --rmintegrations that stranded one container per interrupted dial.connectClientnow passes theEffect.tryPromiseabort signal intoclient.connect. On interruption the SDK fails the handshake and closes the transport (stdin end, then SIGTERM/SIGKILL), so the child exits.discoverToolswraps acquire/use inuninterruptibleMaskso an interrupt landing between the handshake succeeding and theonExitcleanup attaching can no longer leak the connection. Connect and listTools stay restored, so cancellation and the discovery timeout still land promptly.