Skip to content

feat: add .redirect to RequestOptions and support in fetch engine - #448

Merged
kormanowsky merged 11 commits into
v4from
kormanowsky/fetch-redirect-support
Dec 2, 2024
Merged

feat: add .redirect to RequestOptions and support in fetch engine#448
kormanowsky merged 11 commits into
v4from
kormanowsky/fetch-redirect-support

Conversation

@kormanowsky

Copy link
Copy Markdown
Contributor

No description provided.

@kormanowsky
kormanowskyforce-pushed the kormanowsky/fetch-redirect-support branch from e7baeff to 56a5da7CompareNovember 6, 2024 09:47
@gretzkiy
gretzkiy self-requested a review November 15, 2024 07:34

@gretzkiygretzkiy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В движке xhr тоже нужно поддержать, если возможно

@kormanowsky

Copy link
Copy Markdown
ContributorAuthor

@gretzkiy

Не нашел возможности поддержки такого в XHR.
Плюс даже с fetch() это по-разному работает в браузере и в ноде.
Сейчас предполагается использовать только в ноде, так как там в случае redirect manual можно прочитать заголовки ответа, а в браузере - нет. А в ноде XHR по дефолту нет.
Поэтому кажется это и не нужно там?

@shining-mindshining-mind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Только CHANGELOG надо заполнить

@kormanowsky
kormanowskyforce-pushed the kormanowsky/fetch-redirect-support branch from 66d4876 to bfb2c5bCompareDecember 2, 2024 08:27
@kormanowsky
kormanowskyforce-pushed the kormanowsky/fetch-redirect-support branch from bfb2c5b to 2f9ffabCompareDecember 2, 2024 08:27
@kormanowsky
kormanowsky merged commit b8ac308 into v4Dec 2, 2024
@kormanowsky
kormanowsky deleted the kormanowsky/fetch-redirect-support branch December 2, 2024 08:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kormanowsky@gretzkiy@shining-mind