Uh oh!
There was an error while loading. Please reload this page.
Fix/remove once fn proto - #456
Merged
Merged
Conversation
gretzkiyforce-pushed
the
fix/remove-once-fn-proto
branch
3 times, most recently
from
December 25, 2024 07:38
b5f9223 to
206b831Comparegretzkiy
marked this pull request as ready for review
December 25, 2024 08:14
bonkalol
approved these changes
Dec 25, 2024
gretzkiyforce-pushed
the
fix/remove-once-fn-proto
branch
from
December 25, 2024 13:19
206b831 to
cf79bd0Comparekobezzza
approved these changes
Dec 25, 2024
shining-mind
approved these changes
Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to remove
oncefromFunctionprototype in order not to conflict with frameworks that check event handlers properties, i.e. lit/lit#1011 (comment)