Skip to content

feat: TCP in node socket - #846

Merged
al3xa23 merged 10 commits into
masterfrom
node-socket
Feb 4, 2025
Merged

feat: TCP in node socket#846
al3xa23 merged 10 commits into
masterfrom
node-socket

Conversation

@al3xa23

@al3xa23al3xa23 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

inlcude tcp in node-type socket

@al3xa23
al3xa23 requested a review from stv0g as a code ownerJanuary 20, 2025 14:56
stv0g
stv0g requested changes Jan 23, 2025
View reviewed changes
Comment threadinclude/villas/nodes/socket.hpp Outdated
Comment threadinclude/villas/nodes/socket.hpp Outdated
Comment threadtests/integration/node-loopback-socket.sh Outdated
Comment threadlib/nodes/socket.cpp Outdated
Comment threadlib/nodes/socket.cpp Outdated
Comment threadlib/nodes/socket.cpp Outdated
Comment threadlib/nodes/socket.cpp Outdated
Comment threadlib/nodes/socket.cpp Outdated
@stv0gstv0g mentioned this pull request Jan 28, 2025
Merged
stv0g
stv0g requested changes Jan 30, 2025
View reviewed changes
Comment threadlib/nodes/socket.cpp Outdated
@JitpanuM@steffen-vogel-opalrt
feat: Add basic tcp connection to socket node type
62d9c36
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
fix: Comment format and naming
ac0a7a4
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
fix: Add reconnect attempt after the connection is broken.
467b051
Move the establishment of tcp connection out of socket_start so that it will not block other node.
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
feat: Add TCP to the OpenAPI spec of socket node type
b0d2b88
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
feat: Extended integration test for socket TCP connection
ad8199e
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
fix: Uninitialize variable
85904b7
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
fix: Add error checking
da04957
fix: Naming and comment
fix: Remove socket_tcp_connection from header file
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
fix: Remove sleep from socket integration test
1053d9e
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
@JitpanuM@steffen-vogel-opalrt
fix: Comment format
7649709
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
stv0g
stv0g requested changes Jan 30, 2025
View reviewed changes

@stv0gstv0g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @JitpanuM,

I've rebased your changes to the latest master to trigger the CI again.

There is only a last missing/broken error check.

@JitpanuM@n-eiling
fix: Broken error checking
8a1ac3f
Signed-off-by: Jitpanu Maneeratpongsuk <jitpanu.maneeratpongsuk@rwth-aachen.de>
stv0g
stv0g approved these changes Jan 30, 2025
View reviewed changes

@stv0gstv0g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this once the pipeline is passing.

@al3xa23
al3xa23 merged commit c60ef75 into masterFeb 4, 2025
@al3xa23
al3xa23 deleted the node-socket branch February 4, 2025 12:42
@al3xa23al3xa23 mentioned this pull request Feb 14, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JitpanuMJitpanuMJitpanuM left review comments
@stv0gstv0gstv0g approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@al3xa23@stv0g@JitpanuM