Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(config): configurable LLM request timeout by KylinMountain · Pull Request #134 · VectifyAI/OpenKB · GitHub
Skip to content

feat(config): configurable LLM request timeout - #134

Merged
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout
Jun 23, 2026
Merged

feat(config): configurable LLM request timeout#134
KylinMountain merged 5 commits into
mainfrom
feat/configurable-llm-timeout

Conversation

@KylinMountain

Copy link
Copy Markdown
Collaborator

Summary

Adds an optional timeout: config key (seconds), forwarded to LiteLLM's timeout on all of OpenKB's own LLM calls. LiteLLM applies a 600s per-request timeout by default, which slow local backends (e.g. Ollama on large inputs) exceed, raising litellm.Timeout — see #132.

# .openkb/config.yamltimeout: 1200

What changed

  • config: resolve_timeout() validates a finite positive number of seconds (rejects bool / nan / inf / non-numeric); set_timeout() / get_timeout() stash it process-wide, mirroring the existing extra_headers mechanism.
  • compile path: _llm_call / _llm_call_async forward the timeout, without overriding an explicit per-call value.
  • agent paths (query, chat, lint, skill): forwarded via ModelSettings(extra_args={"timeout": ...}), the way extra_headers already reaches them.
  • cli: _setup_llm_key resolves + applies it from .openkb/config.yaml.
  • docs: README documents the key and notes that PageIndex long-document indexing manages its own timeout and is not affected.

Test plan

  • tests/test_config.py — resolver cases incl. nan/inf/bool/non-numeric rejection.
  • tests/test_llm_timeout.py — timeout forwarded / omitted / not-overridden, sync and async.
  • tests/test_cli.py — config → stash wiring + reset-when-absent.
  • tests/test_query.py — agent-path extra_args coverage.
  • Full suite: 824 passed. (The 4 tests/test_url_ingest.py failures are a pre-existing local-env issue — trafilatura not installed — and are unrelated to this change.)

Refs #132. Covers OpenKB's own calls; PageIndex's internal LLM calls hardcode their request and would need an upstream change to honor this.

Add an optional `timeout:` config key, forwarded to LiteLLM's `timeout`
parameter on OpenKB's own LLM calls. LiteLLM defaults to a 600s per-request
timeout, which slow local backends (e.g. Ollama on large inputs) can exceed,
raising `litellm.Timeout`.
- config: resolve_timeout() validates a positive number of seconds;
set_timeout()/get_timeout() stash it process-wide (mirrors extra_headers)
- compiler: _llm_call / _llm_call_async forward the configured timeout,
without overriding an explicit per-call value
- cli: _setup_llm_key resolves + applies it from .openkb/config.yaml
- tests + README
Refs #132. The PageIndex long-doc path hardcodes its own litellm calls and
is unaffected by this (covering it would need an upstream pageindex change).
Addresses self-review of the configurable LLM timeout:
- resolve_timeout(): reject non-finite values (nan/inf, including YAML's
`.nan`/`.inf`) via math.isfinite — they slipped past the `<= 0` guard and
would reach litellm as a bogus timeout (hang on nan, OverflowError on inf).
- Extend the configured timeout to the openai-agents paths (query, chat,
lint, skill) via ModelSettings(extra_args={"timeout": ...}), the way
extra_headers already reaches them. Previously only the compiler calls
honored it, so `openkb chat`/`query`/`lint`/`skill` still hit LiteLLM's 600s.
- Tests: nan/inf rejection; async omit/override symmetry; cli wiring
(config -> stash + reset-when-absent); query-agent extra_args coverage.
- README: note the broadened coverage and that PageIndex indexing is exempt.
- README: list `timeout` in the main config.yaml example (marked optional)
instead of a separate advanced-options paragraph
- config: shorten the resolve_timeout / _runtime_timeout /
get_timeout_extra_args comments
@KylinMountain
KylinMountain merged commit 840f2b7 into mainJun 23, 2026
1 check passed
@KylinMountain
KylinMountain deleted the feat/configurable-llm-timeout branch June 25, 2026 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KylinMountain