Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) by mike-011 · Pull Request #210 · VectifyAI/OpenKB · GitHub
Skip to content

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205) - #210

Open
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop
Open

feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)#210
mike-011 wants to merge 5 commits into
VectifyAI:mainfrom
mike-011:feat/ollama-tool-call-loop

Conversation

@mike-011

@mike-011mike-011 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Fixes#205

When using Ollama models with openkb query and openkb chat, the openai-agents SDK tool-calling loop fails in three ways:

  1. LiteLLM prompt injectionollama/ prefix causes LiteLLM to strip tools and inject them into prompt text with format: json. Model returns tool-call JSON in content instead of tool_calls.
  2. Tool-name hallucination — small models call non-existent tools, causing ModelBehaviorError.
  3. Timeouts — local models take 60-130s per turn; default timeout too short.

Fix

1. Model rewrite: ollama/ to ollama_chat/

Primary fix — LiteLLM uses native Ollama Chat API with tool support.

2. Retry on hallucination

Catches ModelBehaviorError, appends corrective message, retries (configurable, default 3).

3. Parameterized timeouts and retries

New ollama: config block in config.yaml:

ollama:
timeout: 300tool_call_retries: 3

4. drop_params + api_base propagation

Testing

  • 56 adapter unit tests, all passing
  • 1131 total tests, 0 regressions
  • Live E2E: gemma4:12b full tool-loop, 132s

See docs/ollama_tool_call_adapter.md for full documentation.

Add openkb/agent/ollama_adapter.py — a resilient wrapper that catches
ModelBehaviorError when Ollama models hallucinate tool names and retries
with a corrective message listing the actual available tools.
- is_ollama_backend(): detect Ollama models (ollama/ and litellm/ollama/ prefixes)
- arun_with_retry(): wraps Runner.run() with retry on ModelBehaviorError
- run_streamed_with_retry(): wraps Runner.run_streamed() with retry
- _RetryableStreamResult: seamless stream retry via generator
- 26 new tests in tests/test_ollama_adapter.py (all passing)
- query.py patched to use retry wrapper for Ollama backends only
- Non-Ollama path unchanged
Issue: VectifyAI#205
Key improvements over v1:
1. rewrite_ollama_model(): convert ollama/ → ollama_chat/ so LiteLLM
uses native Ollama Chat API with tool support (primary fix).
Without this, LiteLLM falls back to prompt injection and tool calls
never work through the SDK.
2. Configurable timeout: _ensure_ollama_timeout() injects 300s default
into ModelSettings.extra_args for Ollama models, preventing premature
timeouts on slow local hardware.
3. Updated query.py: rewrite applied in build_query_agent() and
build_run_config_from_bundle().
4. 41 tests (up from 26), all passing.
5. 1116 existing tests, all passing.
6. Live test: gemma4:12b full tool-loop completes in 132s.
Issue: VectifyAI#205
Fixes for the full add+query pipeline with Ollama:
1. Module-level OLLAMA_API_BASE propagation in ollama_adapter.py:
- OPENAI_API_BASE → OLLAMA_API_BASE (env var)
- litellm.api_base module setting
So ollama_chat LiteLLM provider finds the endpoint on all paths.
2. compiler.py: pass api_base from env when bundle is None (CLI path)
so litellm.completion/acompletion reaches Ollama for add/concepts.
3. cli.py: rewrite_ollama_model applied to all model resolutions (12 sites)
so ollama/ → ollama_chat/ everywhere, not just query.
4. add_coordinator.py: import ollama_adapter for side effects.
5. drop_params=True set in _ensure_ollama_settings for ollama_chat
(rejects parallel_tool_calls).
Tests: 1116 passed, 0 failed.
Live: add summary=77s OK; query tool-loop=132s OK (SDK E2E verified).
Issue: VectifyAI#205
Add resolve_ollama_settings() to read the 'ollama:' config block:
ollama:
timeout: 300 # per-request timeout (s), default 300
tool_call_retries: 3 # max retries on hallucinated tool names
Timeout precedence: ollama.timeout > litellm.timeout > top-level timeout > 300
Retry precedence: ollama.tool_call_retries > default 3
Changes:
- ollama_adapter.py: resolve_ollama_settings() + all retry/timeout
functions now resolve from config when not explicitly passed
- config.yaml.example: documented ollama: section
- docs/ollama_tool_call_adapter.md: full configuration documentation
- tests/test_ollama_adapter.py: 15 new tests for resolve_ollama_settings
(56 total, all passing; 1131 total suite, 0 failures)
Issue: VectifyAI#205
@mike-011mike-011 changed the title feat(agent): Ollama tool-call retry adapter (fixes #205)feat(agent): Ollama tool-call adapter with parameterized timeouts (fixes #205)Jul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama tool-calling loop does not complete for query/chat on v0.4.5 and v0.5.0-rc1

1 participant

@mike-011