feat(agent): grep-based completeness sweep for the query agent by KylinMountain · Pull Request #84 · VectifyAI/OpenKB

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain · 2026-06-02T07:24:10Z

Summary

Adds a lexical grep capability to the query/chat agent as a final completeness check before it finalizes an answer — backstopping the lossy LLM-generated summary layer. Inspired by "Is Grep All You Need? How Agent Harnesses Reshape Agentic Search" (arXiv:2605.15184): at OpenKB's scale a capable agent + grep matches embedding/vector retrieval, with zero index infrastructure.

Division of labour stays clean:

index.md / summaries — primary breadth (unchanged, still first).
PageIndex — depth within long documents (unchanged).
grep (new) — completeness sweep over the raw *.md layer to catch details summaries dropped, pages never read, and contradicting mentions.

What changed

grep_wiki_files() helper (openkb/agent/tools.py) — shells out to ripgrep (preferred) / grep (fallback) over every wiki *.md (summaries, concepts, entities, explorations, index.md, short-doc sources/*.md); excludes long-doc *.json (PageIndex's domain) and log.md. Injection-safe (shell=False, pattern via -e), result-capped at 50, --no-ignore so gitignored wiki dirs still match, never raises.
grep_wiki agent tool (openkb/agent/query.py) — wraps the helper on the query agent; chat agent inherits it via clone.
"COMPLETENESS SWEEP" instruction — tells the agent to grep the question's salient terms + unsourced draft claims before finalizing, try lexical variants, fold in unread matches, note contradictions with citations, bounded to ≤3 rounds; explicitly a check, not the primary search.

Test Plan

pytest tests/test_grep.py tests/test_query.py → 26 passed
Helper unit tests: scope inclusion/exclusion (json + log.md excluded), case sensitivity, fixed-string vs regex, result cap + truncation notice, relative-path output, shell-injection safety, and the ripgrep branch (mock-verified command construction incl. --no-ignore)
Agent wiring: grep_wiki registered on query agent; chat inherits via clone
Manual: run openkb chat against a KB and confirm the agent greps before answering

Note: 4 unrelated tests/test_url_ingest.py failures are pre-existing (missing optional trafilatura dep), not introduced here.

…und)

…ror, exclusions, guards (addresses code review)

…md test

+
+import pytest
+
+import openkb.agent.tools as tools_mod


…l), not a terminal sweep

KylinMountain · 2026-06-12T09:36:04Z

After some tests, it seems that paying extra for additional tokens does not lead to better results. So just leave it here, if you have better experiment on large dataset, we can consider merge it.

veereshkumar-se · 2026-08-19T11:10:16Z

Formations · PR #84 · e9bfea8f4a0e · NO ACTION

— _{PR tests}	— _Intent	— _Severity	0 _Impacted	— _Selfhealed

_Details

1 · PR tests

No PR test run recorded for this head.

2 · Classification

Intent: — · Severity: —

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

KylinMountain added 5 commits June 2, 2026 12:34

feat(agent): add grep_wiki_files lexical wiki search helper
1c31a7f

test(agent): cover ripgrep branch + entities scope in grep_wiki_files
e9de960

feat(agent): expose grep_wiki tool on the query agent
ea90b00

feat(agent): instruct query agent to grep-sweep for completeness
8abd631

refine(agent): sharpen grep-sweep instruction (scope terms, define ro…
8da312a
…und)

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py Fixed
Comment threadtests/test_grep.py Fixed

KylinMountain added 2 commits June 2, 2026 17:24

fix(agent): grep-only wiki search — fix dialect, encoding, partial-er…
098c7b4
…ror, exclusions, guards (addresses code review)

fix(agent): exclude images/ and .git dirs from grep search; tighten c…
98d26c5
…md test

github-code-qualityBot found potential problems Jun 2, 2026
View reviewed changes

Comment threadtests/test_grep.py

import pytest

import openkb.agent.tools as tools_mod

refine(agent): reframe grep step as locate-then-read (drill for detai…
e9bfea8
…l), not a terminal sweep

Uh oh!

Conversation

KylinMountain commented Jun 2, 2026

Summary

What changed

Test Plan

Uh oh!

Uh oh!

Uh oh!

KylinMountain commented Jun 12, 2026

Uh oh!

veereshkumar-se commented Aug 19, 2026

—

—

—

0

—

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

KylinMountain commented Jun 2, 2026

Summary

What changed

Test Plan

Uh oh!

Uh oh!

Uh oh!

KylinMountain commented Jun 12, 2026

Uh oh!

veereshkumar-se commented Aug 19, 2026

—

—

—

0

—

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

KylinMountain commented Jun 2, 2026

Summary

What changed

Test Plan

Uh oh!

Uh oh!

Uh oh!

KylinMountain commented Jun 12, 2026

Uh oh!

veereshkumar-se commented Aug 19, 2026

—

—

—

0

—

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation