') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add UPnP album art fallback by MagicMicky · Pull Request #127 · Velleman/python-linkplay · GitHub
Skip to content

Add UPnP album art fallback - #127

Open
MagicMicky wants to merge 1 commit into
Velleman:mainfrom
MagicMicky:upnp-metadata-fallback
Open

Add UPnP album art fallback#127
MagicMicky wants to merge 1 commit into
Velleman:mainfrom
MagicMicky:upnp-metadata-fallback

Conversation

@MagicMicky

@MagicMickyMagicMicky commented Jul 4, 2026

Copy link
Copy Markdown

What this does

Many LinkPlay devices don't expose album art through the HTTP API. On these
devices getMetaInfo returns unknown command and getPlayerStatus(Ex) has
no art field, so player.album_art is always empty and downstream consumers
(e.g. the Home Assistant integration) show no cover.

The art is available through the device's UPnP AVTransport service. This adds a
fallback: when album_art is empty after the normal HTTP update, it queries
AVTransport.GetMediaInfo and reads albumArtURI from the returned DIDL-Lite
metadata, storing it in the existing metainfo structure so album_art keeps
working unchanged.

Details

  • New linkplay/upnp.py with a small LinkPlayUPnP helper built on
    async_upnp_client (already an install dependency). The UpnpDevice is
    created once and reused.
  • The trigger is manufacturer-agnostic: it fires whenever album art is missing,
    so it also helps WiiM devices that occasionally omit it, rather than
    hard-coding a WiiM / non-WiiM split.
  • The DIDL is parsed with defusedxml (added to install_requires) to avoid
    XXE and entity-expansion attacks on the device response.
  • Non-URL placeholders (devices report un_known when nothing is playing or on
    followers) are validated away to None.
  • Adds host and session accessors on LinkPlayApiEndpoint for the UPnP
    client.

Testing

  • New tests/linkplay/test_upnp.py covers DIDL parsing (a real Spotify
    albumArtURI, the un_known placeholder, and malformed input) and the
    GetMediaInfo paths.
  • New bridge tests assert album art is fetched via UPnP when missing and that
    UPnP is skipped when the HTTP API already provides it.
  • ruff, mypy and the full test suite pass.

Verified against real hardware: Arylic Up2Stream Pro V4 and Audio Pro C10, both
playing Spotify, where the Spotify cover URL is exposed via albumArtURI.

Scope

Relates to #68. This intentionally does not close it: using UPnP as a full
replacement for devices that don't support getPlayerStatusEx at all (transport
state, position, volume via RenderingControl) is a larger change. The
properties dict would be empty and the numeric and enum accessors (int(""),
LoopMode("")) would raise, so it needs seeded defaults and additional UPnP
actions. That is left as a follow-up. This builds on the exploration in the
draft #102 by @silamon.

@MagicMicky
Add UPnP album art fallback
4d2488e
Many LinkPlay devices (e.g. Arylic and Audio Pro models) do not expose
album art through the HTTP API; the art is only available through the
device's UPnP AVTransport service. When getPlayerStatusEx does not provide
album art, fall back to UPnP GetMediaInfo and read the albumArtURI, keeping
the value in the existing metainfo structure so album_art works unchanged.
The fallback is manufacturer-agnostic: it triggers whenever album art is
missing, which also helps WiiM devices that occasionally omit it. Non-URL
placeholders (e.g. "un_known") are discarded.
Relates to Velleman#68. UPnP as a full replacement for devices without
getPlayerStatusEx (including transport state and volume) is left as a
follow-up. Builds on the exploration in the draft Velleman#102.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MagicMicky