Add support for LEGO The Lord of the Rings - #166
Merged
Merged
Conversation
Venomalia
reviewed
Feb 28, 2023
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might want to check this over, since it's my first time contributing to the project. It should be working, at least on the devices I have access to and can test (DInput/0/Keyboard Mouse, WGInput/0/Xbox One Game Controller, SDL/0/Xbox One S Controller).
I've added "SDL/0/Xbox One S Controller" as a default device in the UniversalDIT_Simple-Default.json using the Xbox One icons in the "#Default Devices" folder. (See Issue #165) Hopefully that saves a bit of work.
One of the textures that needed to be replaced is the menu "Show Controls" screen. This displayed a single texture with a control map baked in, so I had to alter it a bit to work with dynamic icons. However, this required icons without transparency to have them display correctly, so I've created icons with a single colour background for all the default devices using the existing Simple-Default style icons. I placed these icons in the "Simple-Default_BrownBG" folder and set up the .json to point to those textures when replacing the control map.
I don't know if this is the best way to go about this, so if you have suggestions for a better way I'd be happy to change it.
Let me know if you need any more information, see any mistakes, or need me to change something!