Parse the built in ISO date format with the invariant culture - #1884
Merged
Merged
Conversation
Every TryParseExact in the date scrubber passed a null provider, so the built in ISO format was parsed with the ambient culture and its calendar, while DateFormatter writes with the invariant culture. Under th-TH (Buddhist) 2023-08-29T10:11:12 parsed as Gregorian 1480, so the MinValue and MaxValue sentinels and the named date lookups stopped matching. Under ar-SA (UmAlQura) the parse failed outright and ISO timestamps were left unscrubbed, making snapshot content differ by machine with the default on ScrubDateTimes. Formats registered through AddExtraDateTimeFormat keep parsing with the ambient culture: the test supplies both those formats and the values they match, and the default 'd' and 'h:mm tt' are culture specific by design.
This was referenced Sep 12, 2026
This was referenced Sep 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every TryParseExact in the date scrubber passed a null provider, so the built in ISO format was parsed with the ambient culture and its calendar, while DateFormatter writes with the invariant culture.
Under th-TH (Buddhist) 2023-08-29T10:11:12 parsed as Gregorian 1480, so the MinValue and MaxValue sentinels and the named date lookups stopped matching. Under ar-SA (UmAlQura) the parse failed outright and ISO timestamps were left unscrubbed, making snapshot content differ by machine with the default on ScrubDateTimes.
Formats registered through AddExtraDateTimeFormat keep parsing with the ambient culture: the test supplies both those formats and the values they match, and the default 'd' and 'h:mm tt' are culture specific by design.