LOG-3949: Vector not releasing deleted file handles

[syedriko]

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to practical infinity. Out of the box, this default effectively turns this feature off. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait, of type Duration, defaulting to 5 seconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait, of type Duration, defaulting to 5 seconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to 5,000 milliseconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to 5000 milliseconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[syedriko]

/test unit

[syedriko]

/test unit

[syedriko]

/test unit

[syedriko]

/assign @jcantrill

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to 5000 milliseconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/hold
/approve

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to 5000 milliseconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to 5000 milliseconds. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[syedriko]

@jcantrill PTAL

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to practical infinity. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to practical infinity. Out of the box, this default effectively turns this feature off. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/hold cancel
/lgtm

[openshift-ci-robot]

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Details

In response to this:

For the file and kubernetes_logs sources, introduced a new configuration variable, rotate_wait_ms, of type Duration, defaulting to practical infinity. Out of the box, this default effectively turns this feature off. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.
This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced - vector_file_deleted_given_up_total, which is a counter.

JIRA:
https://issues.redhat.com/browse/LOG-3949

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.