Skip to content

Enable Opentelemetry source and sink feature - #199

Closed
vparfonov wants to merge 1 commit into
ViaQ:v0.43.1-rhfrom
vparfonov:log6908
Closed

Enable Opentelemetry source and sink feature#199
vparfonov wants to merge 1 commit into
ViaQ:v0.43.1-rhfrom
vparfonov:log6908

Conversation

@vparfonov

@vparfonovvparfonov commented Apr 11, 2025

Copy link
Copy Markdown

No description provided.

@vparfonov
Enable Opentelemetry source and sink feature
b6bdbfd
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci

openshift-ciBot commented Apr 11, 2025•
edited
Loading

Copy link
Copy Markdown

@vparfonov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/cluster-logging-operator-e2eb6bdbfdlinktrue/test cluster-logging-operator-e2e
ci/prow/clo-functionalb6bdbfdlinktrue/test clo-functional

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vparfonov

vparfonov commented Apr 11, 2025

Copy link
Copy Markdown
Author

/test unit

jcantrill
jcantrill reviewed Apr 21, 2025
View reviewed changes
Comment threadlib/vector-core/src/tls/incoming.rs
}
}

#[derive(Clone)]

@jcantrilljcantrillApr 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we remove this in a prior change? Why does enabling otel require us to do anything other then modify the Cargo.toml?

@vparfonovvparfonovApr 21, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was removed in some reason during updating to the Vector v0.33.0, i met the same error what was fixed here: #198

jcantrill
jcantrill reviewed Apr 21, 2025
View reviewed changes

@jcantrilljcantrill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/approve

@openshift-ci

openshift-ciBot commented Apr 21, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vparfonov
vparfonov deleted the log6908 branch July 13, 2025 10:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrilljcantrilljcantrill left review comments
@cahartmacahartmaAwaiting requested review from cahartma
@Clee2691Clee2691Awaiting requested review from Clee2691

Assignees

No one assigned

Labels

approveddo-not-merge/holdv0.43

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vparfonov@jcantrill