Skip to content

LOG-9375: Enhance the prometheus exporter with SAR auth strategy - #265

Merged
openshift-merge-bot[bot] merged 5 commits into
ViaQ:v0.54.0-rhfrom
jcantrill:log9375
May 6, 2026
Merged

LOG-9375: Enhance the prometheus exporter with SAR auth strategy#265
openshift-merge-bot[bot] merged 5 commits into
ViaQ:v0.54.0-rhfrom
jcantrill:log9375

Conversation

@jcantrill

Copy link
Copy Markdown
Member

This PR:

  • Adds auth.strategy 'sar' (SubjectAccessReview) to the prometheus export sink
  • Allows the sink to be protected by a well-known kubernetes pattern

Tested by granting the collector service account the permissions identified in the API notes and configuring like:

 [sinks.prometheus_output.auth]
strategy = "sar"
path = "/metrics"
verb = "get"

Ref: https://redhat.atlassian.net/browse/LOG-9375

cc @vparfonov

@openshift-ci-robot

openshift-ci-robot commented May 1, 2026

Copy link
Copy Markdown

@jcantrill: This pull request references LOG-9375 which is a valid jira issue.

Details

In response to this:

This PR:

  • Adds auth.strategy 'sar' (SubjectAccessReview) to the prometheus export sink
  • Allows the sink to be protected by a well-known kubernetes pattern

Tested by granting the collector service account the permissions identified in the API notes and configuring like:

 [sinks.prometheus_output.auth]
strategy = "sar"
path = "/metrics"
verb = "get"

Ref: https://redhat.atlassian.net/browse/LOG-9375

cc @vparfonov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ciBot requested a review from Clee2691May 1, 2026 18:24
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill

Copy link
Copy Markdown
MemberAuthor

/label tide/merge-method-squash

@openshift-ci

Copy link
Copy Markdown

@jcantrill: The label(s) tide/merge-method-squash cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcantrill

Copy link
Copy Markdown
MemberAuthor

/test cargo-clippy-check

Comment threadsrc/sinks/prometheus/exporter.rs Outdated
Comment threadsrc/sinks/prometheus/exporter.rs Outdated
Comment threadsrc/sinks/prometheus/exporter.rs
@jcantrill

Copy link
Copy Markdown
MemberAuthor

/test unit

@jcantrill

Copy link
Copy Markdown
MemberAuthor

/hold

@jcantrill

Copy link
Copy Markdown
MemberAuthor

/label tide/merge-method-squash

@openshift-ci

Copy link
Copy Markdown

@jcantrill: The label(s) tide/merge-method-squash cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcantrill

Copy link
Copy Markdown
MemberAuthor

/hold cancel

@vparfonov

Copy link
Copy Markdown

/lgtm

@openshift-merge-bot
openshift-merge-botBot merged commit 1808a37 into ViaQ:v0.54.0-rhMay 6, 2026
9 checks passed
@jcantrill
jcantrill deleted the log9375 branch May 7, 2026 15:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jcantrill@openshift-ci-robot@vparfonov