Skip to content

fix(security): LOG-2552 Investigate the changes required to make Vector use OpenSSL - #61

Merged
vimalk78 merged 7 commits into
ViaQ:v0.21-rhfrom
syedriko:syedriko_log_2552
Jun 14, 2022
Merged

fix(security): LOG-2552 Investigate the changes required to make Vector use OpenSSL#61
vimalk78 merged 7 commits into
ViaQ:v0.21-rhfrom
syedriko:syedriko_log_2552

Conversation

@syedriko

@syedrikosyedriko commented Jun 2, 2022•
edited
Loading

Copy link
Copy Markdown

LOG-2552: [spike] Investigate the changes required to make Vector use OpenSSL
For FIPS compliance, make sure

  • all crypto is done in OpenSSL
  • OpenSSL is linked dynamically

Commits are separate for ease of review and will be sqwashed before merge.

@syedriko

syedriko commented Jun 2, 2022

Copy link
Copy Markdown
Author

/assign @vimalk78

@jcantrill

jcantrill commented Jun 2, 2022

Copy link
Copy Markdown
Member

@syedriko I assume this is mostly vendored code with strategic changes to make openssl work. Have you submitted upstream patches?

@syedriko

syedriko commented Jun 2, 2022

Copy link
Copy Markdown
Author

@syedriko I assume this is mostly vendored code with strategic changes to make openssl work. Have you submitted upstream patches?

That's exactly right. No, no upstream patches yet, I'd like to make sure these changes work with the rest of vector first.

@openshift-ci

openshift-ciBot commented Jun 13, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: syedriko
To complete the pull request process, please ask for approval from vimalk78 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@syedriko
LOG-2552:
fa7f7b9
- added installation of cargo-nextest to Dockerfile.unit so
the unit tests would run in CI
- added the patch dir to .dockerignore so it would get copied into
vector container images
@syedriko
LOG-2552: checked in cargo-nextest
727da05
@vimalk78

vimalk78 commented Jun 14, 2022

Copy link
Copy Markdown

/lgtm
able to build ppc image locally. ring does not get built.

@vimalk78

vimalk78 commented Jun 14, 2022

Copy link
Copy Markdown

merging the PR to unblock builds
will add another PR to fix the three failing Cross test suites. These are failing for a missing file

@vimalk78

vimalk78 commented Jun 14, 2022

Copy link
Copy Markdown

/retest

@openshift-ci

openshift-ciBot commented Jun 14, 2022

Copy link
Copy Markdown

@syedriko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/unit727da05linktrue/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vimalk78

vimalk78 commented Jun 14, 2022

Copy link
Copy Markdown

/lgtm
Merging

@vimalk78
vimalk78 merged commit 9e8ff9b into ViaQ:v0.21-rhJun 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrilljcantrillAwaiting requested review from jcantrill
@pmoogi-redhatpmoogi-redhatAwaiting requested review from pmoogi-redhat

Assignees

@vimalk78vimalk78

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@syedriko@jcantrill@vimalk78