Uh oh!
There was an error while loading. Please reload this page.
ci(maven): groupId -> com.vibetensor + Central Portal publish workflow - #1
Conversation
…al publish - groupId corrected to the VERIFIED namespace com.vibetensor (vibetensor.io was never ours; com.vibetensor verified via DNS TXT on vibetensor.com). - Swap legacy OSSRH (s01.oss.sonatype.org) for the vanniktech Central-Portal publisher (central.sonatype.com), which is what the portal account uses. - Tag-triggered publish.yml: token + GPG key via encrypted repo secrets, tag==version guard + conformance tests before publish. - Artifact coordinates: com.vibetensor:attestix:0.4.0.
📝 WalkthroughWalkthroughThis PR establishes automated Maven Central publishing by migrating the Gradle build from legacy OSSRH publishing to the ChangesMaven Central Publishing Setup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
44-45: 💤 Low valueConsider disabling Gradle cache for publishing workflow security.
The
gradle/actions/setup-gradleaction enables caching by default, which static analysis flagged as a cache-poisoning vector. For tag-triggered publishing workflows, the risk is lower than for PR workflows, but disabling caching provides defense-in-depth for a critical release pipeline.🔧 Proposed fix to disable caching
# gradle/actions/setup-gradle v4.2.2 - uses: gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b + with:+ cache-disabled: true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/publish.yml around lines 44 - 45, The gradle setup step currently uses the action reference "gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b" which enables caching by default; update that step to explicitly disable the action's cache input (e.g., add the action input key "cache" set to false) so the setup-gradle step no longer creates or restores Gradle caches for the publish/tag workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish.yml:
- Around line 35-36: The checkout step using
actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 should disable
credential persistence; update the checkout step (the step that uses
actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5) to include with:
persist-credentials: false so Git credentials are not stored in the workspace
during the GPG signing workflow.
---
Nitpick comments:
In @.github/workflows/publish.yml:
- Around line 44-45: The gradle setup step currently uses the action reference
"gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b" which
enables caching by default; update that step to explicitly disable the action's
cache input (e.g., add the action input key "cache" set to false) so the
setup-gradle step no longer creates or restores Gradle caches for the
publish/tag workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f5503ede-720a-445f-a3ca-670b8e13e74e
📒 Files selected for processing (2)
.github/workflows/publish.ymlbuild.gradle.kts
| # actions/checkout v4.3.0 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 |
There was a problem hiding this comment.
Disable credential persistence for improved security posture.
In a workflow handling GPG signing keys, setting persist-credentials: false prevents Git credentials from being stored in the workspace, reducing the attack surface.
🛡️ Proposed fix
# actions/checkout v4.3.0
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5
+ with:+ persist-credentials: false📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # actions/checkout v4.3.0 | |
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | |
| # actions/checkout v4.3.0 | |
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | |
| with: | |
| persist-credentials: false |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/publish.yml around lines 35 - 36, The checkout step using
actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 should disable
credential persistence; update the checkout step (the step that uses
actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5) to include with:
persist-credentials: false so Git credentials are not stored in the workspace
during the GPG signing workflow.
Uh oh!
There was an error while loading. Please reload this page.
Fixes groupId to the verified com.vibetensor namespace + switches to the Central Portal publisher (vanniktech). Tag-triggered, secrets via GitHub UI. After merge + GPG/token secrets added, push v0.4.0 to publish com.vibetensor:attestix:0.4.0.
Summary by CodeRabbit