Uh oh!
There was an error while loading. Please reload this page.
Search for the openh264 soname on macOS - #28
Merged
Conversation
The installer writes the dylib as libopenh264.8.dylib, the soname FreeRDP's load command requires, but the loader only ever looked for libopenh264.dylib. The path never existed, the system-wide fallback missed it too, and webcam H264 silently degraded to MJPEG on every Mac. Collapse the per-OS path and fallback lists into a single LIB_NAMES table so the two cannot drift apart again, and cover the macOS list with the soname. Linux already listed its versioned sonames; macOS did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer writes the dylib as libopenh264.8.dylib, the soname FreeRDP's load command requires, but the loader only ever looked for libopenh264.dylib. The path never existed, the system-wide fallback missed it too, and webcam H264 silently degraded to MJPEG on every Mac.
Collapse the per-OS path and fallback lists into a single LIB_NAMES table so the two cannot drift apart again, and cover the macOS list with the soname. Linux already listed its versioned sonames; macOS did not.