fix(deeplink): use a live settings section in tests - #260
Merged
Merged
Conversation
7ebde60 dropped the "vaults" SETTINGS_SECTIONS id and fixed deepLinkUrl.test.ts to match, but missed deepLink.test.ts, which kept building settings deep links with the now-invalid section — parseDeepLink silently rejected them, red on CI since. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
kipavy
force-pushed
the
fix/deeplink-settings-section-test
branch
from
September 11, 2026 09:12
a06bd27 to
e73ebe5
Compare
kipavy
added a commit
that referenced
this pull request
Sep 11, 2026
7ebde60 dropped the "vaults" SETTINGS_SECTIONS id and fixed deepLinkUrl.test.ts to match, but missed deepLink.test.ts, which kept building settings deep links with the now-invalid section — parseDeepLink silently rejected them, red on CI since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
7ebde608dropped the"vaults"SETTINGS_SECTIONSid and fixeddeepLinkUrl.test.tsto match, but misseddeepLink.test.ts, which kept building settings deep links with the now-invalid sectionparseDeepLinksilently rejected them, leavingbuildred onmain(2 failures insrc/services/deepLink.test.ts)section=vaultsforsection=sync, same substitution already applied indeepLinkUrl.test.tsTest plan
npx vitest run src/services/deepLink.test.ts— 23/23 passing🤖 Generated with Claude Code