Skip to content
This repository was archived by the owner on Dec 13, 2021. It is now read-only.

feat: add embed builder and migrate current commands to embeds - #41

Merged
Niggelgame merged 5 commits into
developfrom
feature/embeds
Jun 6, 2021
Merged

feat: add embed builder and migrate current commands to embeds#41
Niggelgame merged 5 commits into
developfrom
feature/embeds

Conversation

@Niggelgame

@NiggelgameNiggelgame commented Jun 6, 2021

Copy link
Copy Markdown

resolves#38

@DRSchlaubi

DRSchlaubi commented Jun 6, 2021

Copy link
Copy Markdown
Member

Run gradlew ktlintFormat to fix the CI

DRSchlaubi
DRSchlaubi suggested changes Jun 6, 2021
View reviewed changes
Comment threadsrc/main/kotlin/dev/schlaubi/votebot/commands/ClaimPermissionsCommand.kt Outdated
Comment threadsrc/main/kotlin/dev/schlaubi/votebot/core/VoteBotImpl.kt Outdated
Comment threadsrc/main/kotlin/dev/schlaubi/votebot/util/Colors.kt Outdated
@Suppress("KDocMissingDocumentation", "unused", "MagicNumber")
object Colors {
// Discord
val BLURLPLE: Color = Color(114, 137, 218)

@DRSchlaubiDRSchlaubiJun 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are actually wrong update them to match the new branding

@NiggelgameNiggelgameJun 6, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove all the non-existing colors?

@NiggelgameNiggelgameJun 6, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or e.g. replace the current LIGHT_GREEN with the branding GREEN

@NiggelgameNiggelgameJun 6, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DRSchlaubi

Comment threadsrc/main/kotlin/dev/schlaubi/votebot/util/Embeds.kt Outdated
Comment threadsrc/main/kotlin/dev/schlaubi/votebot/util/Embeds.kt Outdated
Comment threadsrc/main/kotlin/dev/schlaubi/votebot/util/Embeds.kt Outdated
@DRSchlaubiDRSchlaubi linked an issue Jun 6, 2021 that may be closed by this pull request
Update embeds #38
Closed
@DRSchlaubi

DRSchlaubi commented Jun 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member

The base branch requires all commits to be signed. Learn more about signing commits.

DUDE

@Niggelgame

Niggelgame commented Jun 6, 2021

Copy link
Copy Markdown
Author

freak i used the wrong git profile

@DRSchlaubi

DRSchlaubi commented Jun 6, 2021

Copy link
Copy Markdown
Member

freak i used the wrong git profile

just rebase
squash
and sign that

@Niggelgame

Niggelgame commented Jun 6, 2021

Copy link
Copy Markdown
Author

actually forgot the squash

but fr took long enough for me to rebase on my own branch... until i found the IJ command to rebase on the root of the branch

@Niggelgame
Niggelgame merged commit dfc9b29 into developJun 6, 2021
@Niggelgame
Niggelgame deleted the feature/embeds branch June 6, 2021 20:45
@DRSchlaubiDRSchlaubi mentioned this pull request Jun 6, 2021
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@DRSchlaubiDRSchlaubiDRSchlaubi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update embeds

2 participants

@Niggelgame@DRSchlaubi