Uh oh!
There was an error while loading. Please reload this page.
feat(Registration): Email verification - #335
Conversation
…ch any users in database
…y/WISE-API into email-verification
hirokiterashima
left a comment
There was a problem hiding this comment.
New changes look good!
I added some more code improvement suggestions inline. Lmk if you have any questions or want to discuss!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hirokiterashima
left a comment
There was a problem hiding this comment.
It looks like there's a small possibility that a teacher will not be able to create a new account if the SMTP server does not send an email. For example, this could happen when the SMTP server reaches its daily send limit. To address this, we might want to limit the amount of verification emails on the server (wise-api) side. Let's think about this a bit more together.
Changes
Test
ADD COLUMN isVerified BIT(1) NOT NULL DEFAULT TRUE,
ADD COLUMN verificationCode VARCHAR(255) NULL;
Other