Skip to content

Custom Theming Support - #224

Open
versx wants to merge 7 commits into
masterfrom
themes
Open

Custom Theming Support#224
versx wants to merge 7 commits into
masterfrom
themes

Conversation

@versx

@versxversx commented Sep 24, 2020

Copy link
Copy Markdown
Collaborator

Better implementation of #218 to allow you to create beautiful and elegant themes like the following:
Omg: (originally named Mygod 😉)

TODO:

  • Remove server side theme option

image

Default:
image

Blue:
image

Dark:
image

Light:
image

Green:
image

@versxversx changed the title Add custom themesCustom Theming SupportSep 24, 2020
@versxversx mentioned this pull request Sep 24, 2020

@clburlisonclburlison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile support 🙂😅

image

@versx

Copy link
Copy Markdown
CollaboratorAuthor

Mobile support 🙂😅

image

Oof, thanks

@clburlisonclburlison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MygodMygod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now whenever I write a new style I need to write it in five different css.example too or check that they work correctly for all five example themes and pray that it does not break some custom themes? What a terrible idea. No thanks.

@versx

Copy link
Copy Markdown
CollaboratorAuthor

So now whenever I write a new style I need to write it in five different css.example too or check that they work correctly for all five example themes and pray that it does not break some custom themes? What a terrible idea. No thanks.

You write it for that one theme...

@Mygod

Copy link
Copy Markdown
Contributor

As I said you still need to test them all. Not very excited.

@versxversx added the enhancement New feature or request label Sep 27, 2020
@versx

versx commented Mar 11, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Anyone have any suggestions for improving this so @Mygod doesn't have to update each template when there's changes?

@Mygod

Copy link
Copy Markdown
Contributor

Maybe have some guidelines for contributing, so that everyone knows how to add a UI element that will be consistent with themes?

@versx

Copy link
Copy Markdown
CollaboratorAuthor

Maybe have some guidelines for contributing, so that everyone knows how to add a UI element that will be consistent with themes?

Thanks, that's a good idea.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@versx@Mygod@clburlison