Update birthdays to Date rather than DateTime by karbassi · Pull Request #839 · WeAllCode/website

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

karbassi · 2021-01-15T22:36:54Z

Allow students up to 18 by default.

- Allow students up to 18 by default.

rgroves

Gonna send through a commit for the one change I noted.

rgroves · 2021-01-16T18:32:27Z


 {% block extra_script %}
-<script src="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.js"></script>
+<script src="https://unpkg.com/js-datepicker@5.18.0/dist/datepicker.min.js"></script>


Just making a note, (possibly make a separate issue for future enhancement), to consider using a Subresource Integrity attribute for externally sourced script files like this one.

~~Also, noticed on lines 7-9 this datepicker is included again:~~
{% block extra_head %} <link rel="stylesheet" href="https://unpkg.com/js-datepicker@5.14.2/dist/datepicker.min.css"> {% endblock %}
~~I'll remove this and send through a commit.~~
Disregard the above. I just realized that is CSS and not JS that is being included in the extra head block.
Though the CSS version, I assume should match the JS version, which it does not currently (5.14.2 vs 5.18.0).

rgroves · 2021-01-16T20:23:20Z

+ ]
+
+ operations = [
+ migrations.AlterField(


Is this alter for first_name supposed to be here? Doesn't make sense to be included here so just pointing it out to make sure it was intended.

rgroves · 2021-01-16T22:41:25Z

Also of note:
Seemed to contain changes unrelated to birthdays

Pipfile.lock
coderdojochi/templates/welcome.html
fixtures/07-coderdojochi.location.json
fixtures/14-coderdojochi.session.json

Admin area does not enforce the age constraint for student. Though it is enforced in the Guardian add student form. Not sure if that was intentional or not.

rgroves · 2021-01-17T00:04:05Z

Was running through testing, in dj-admin the date field now shows it is a date only (no longer requires time) for mentor, guardian, and student—so the migrations seems to be working as intended.

As a guardian, I was able to add a 19 year old student though with birthdate 1/16/2002. Noticed the change in coderdojochi/forms.py is what allows this, the min birthdate calculation uses an offset of -19 years. Intended or typo?

Update birthdays to Date rather than DateTime
5ae4549
- Allow students up to 18 by default.

karbassi requested a review from rgroves January 15, 2021 22:37