Uh oh!
There was an error while loading. Please reload this page.
Feature/about us first section - #107
Conversation
✅ Deploy Preview for priceless-booth-2dfcaf ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cherylli
commented
Jun 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
cherylli
commented
Jun 15, 2022
Not sure if there's already a mobile design. Can't find it on figma, so just using the default TwoColumn mobile view. |
mariana-caldas
left a comment
There was a problem hiding this comment.
This new file structure makes so much sense, @cherylli ! Thanks so much, you rock! 🚀
I just see some minor adjustments. Feel free to reach out if you have questions about them.
Could you please request my review again whenever it is ready?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wenebob
left a comment
There was a problem hiding this comment.
The First section looks great! Everything seems to be on point. However, concerning the mobile view, I want to suggest that under the 'About Web Dev Path' heading the images should come before the paragraph rather than after. Great job
Thanks. As mentioned above there's no official mobile design yet. so this might be a suggestion to the @Web-Dev-Path/designers team. |
mariana-caldas
left a comment
There was a problem hiding this comment.
The path organization is amazing, @cherylli ! Such a great job! Could you pls just make the Github and Bitbucket links and connect them to their respective pages?
mariana-caldas
left a comment
There was a problem hiding this comment.
Yay! "Habemus" first section, @cherylli ! Great job! 🥇
Can you just wait until Wednesday to merge it so we give some time for more reviews?
cherylli
commented
Jun 20, 2022
Should we set up a project specific file like prettier or eslint for formatting consistency? I normally use single quotes for most things in js so my auto formatter might have done that. |
mariana-caldas
commented
Jun 20, 2022
You're absolutely right! We actually added |
…ath/web-dev-path into feature/about-us-first-section

Have you updated the CHANGELOG.md file? If not, please do it.
yes
What is this change?
Were there any complications while making this change?
no
How did you verify this change?
Run locally in mobile and desktop mode in different screen sizes
When should this be merged?
After review