Uh oh!
There was an error while loading. Please reload this page.
[Parser][NFC] Remove Token from lexer interface - #6333
Merged
Conversation
MemberAuthor
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
kripken
approved these changes
Feb 22, 2024
kripken
left a comment
Member
There was a problem hiding this comment.
This change is a prerequisite for simplifying the lexer implementation by removing
Tokenentirely.
Perhaps a Token-based interface will be useful eventually for something? But lgtm if you don't expect that.
tlively
commented
Feb 22, 2024
MemberAuthor
I think the |
MemberAuthor
Replace the general `peek` method that returned a `Token` with specific peek methods that look for (but do not consume) specific kinds of tokens. This change is a prerequisite for simplifying the lexer implementation by removing `Token` entirely.
tlivelyforce-pushed
the
parser-no-token-peek
branch
from
February 22, 2024 17:09
2c5b813 to
7a7258cCompareradekdoulik pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Replace the general `peek` method that returned a `Token` with specific peek methods that look for (but do not consume) specific kinds of tokens. This change is a prerequisite for simplifying the lexer implementation by removing `Token` entirely.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the general
peekmethod that returned aTokenwith specific peekmethods that look for (but do not consume) specific kinds of tokens. This change
is a prerequisite for simplifying the lexer implementation by removing
Tokenentirely.