Skip to content

Updated Microsoft Edge logo on home page - #239

Closed
sidverma32 wants to merge 2 commits into
WebAssembly:mainfrom
sidverma32:pr/update-hompeage-edge-logo
Closed

sidverma32 wants to merge 2 commits into
WebAssembly:mainfrom
sidverma32:pr/update-hompeage-edge-logo

Conversation

@sidverma32

@sidverma32 sidverma32 commented May 11, 2021

Copy link
Copy Markdown

Problem

The Edge logo on the home page is the old "E" logo used by the non-Chromium based Edge.

ChangeLog

Updated the Edge browser logo to a new one.

@sidverma32 sidverma32 changed the title updated homepage edge logo Updated Microsoft Edge logo on home page May 11, 2021
@RReverser

Copy link
Copy Markdown
Member

Please pass SVG via a compressor like https://jakearchibald.github.io/svgomg/.

@sidverma32

Copy link
Copy Markdown
Author

Please pass SVG via a compressor like https://jakearchibald.github.io/svgomg/.

Sure, pushed the change.

@RReverser

Copy link
Copy Markdown
Member

The Edge logo on the home page is the old "E" logo used by the non-Chromium based Edge.

Hm, thinking about this a bit more... the point of that row was to say that 4 major engines (including the non-Chrome Edge) has shipped WebAssembly support.

If we switch to the Chromium-based Edge logo, we might as well remove its mention altogether, because in terms of engine it's the same one as Chrome...

@sidverma32

Copy link
Copy Markdown
Author

@RReverser Thanks for describing the problem statement. But i am little less familiar with the repo., if you can give me a heads-up on the pointer which you said like from where to begin.

@andylizi

andylizi commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

This change was merged in #283, which I included as part of another project because I hadn't noticed you've already submitted this PR. I apologize for wasting your time:pensive:.

#231 can also be closed now.

@chicoxyzzy

Copy link
Copy Markdown
Member

Fixed in #283

@chicoxyzzy chicoxyzzy closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants